Bug 110628 - [BlackBerry] cookies set on a 401 response are not included when retrying with credentials
Summary: [BlackBerry] cookies set on a 401 response are not included when retrying wit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joe Mason
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-22 11:13 PST by Joe Mason
Modified: 2013-02-22 14:18 PST (History)
5 users (show)

See Also:


Attachments
fix (13.21 KB, patch)
2013-02-22 11:14 PST, Joe Mason
no flags Details | Formatted Diff | Diff
patch with style fixes (12.88 KB, patch)
2013-02-22 11:48 PST, Joe Mason
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Mason 2013-02-22 11:13:29 PST
When a 401 or 407 response includes a Set-Cookie header, it is saved in the cookie jar. But after querying the user for auth credentials, the followup request re-uses the cookies from the original request rather than rereading them from the cookie jar, so the new cookie is not included. This breaks some sites that use cookies for custom auth schemes.
Comment 1 Joe Mason 2013-02-22 11:14:40 PST
Created attachment 189795 [details]
fix
Comment 2 Joe Mason 2013-02-22 11:48:32 PST
Created attachment 189801 [details]
patch with style fixes
Comment 3 WebKit Review Bot 2013-02-22 14:18:30 PST
Comment on attachment 189801 [details]
patch with style fixes

Clearing flags on attachment: 189801

Committed r143796: <http://trac.webkit.org/changeset/143796>
Comment 4 WebKit Review Bot 2013-02-22 14:18:33 PST
All reviewed patches have been landed.  Closing bug.