SSIA.
Created attachment 189786 [details] Patch
Comment on attachment 189786 [details] Patch Ok.
Comment on attachment 189786 [details] Patch Clearing flags on attachment: 189786 Committed r143767: <http://trac.webkit.org/changeset/143767>
All reviewed patches have been landed. Closing bug.
Previous patch caused regression when a raw modifier key came through. Updating to be more strict.
Created attachment 190294 [details] Patch
Comment on attachment 190294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190294&action=review > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1669 > } > +bool InputHandler::isNavigationKey(unsigned character) const need a space?
Created attachment 190512 [details] Updated patch with space fixed.
Created attachment 190514 [details] Fix missing header.
Comment on attachment 190514 [details] Fix missing header. LGTM.
Comment on attachment 190514 [details] Fix missing header. Rejecting attachment 190514 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 190514, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Full output: http://webkit-commit-queue.appspot.com/results/16831294
Comment on attachment 190514 [details] Fix missing header. Clearing flags on attachment: 190514 Committed r144193: <http://trac.webkit.org/changeset/144193>