Bug 110605 - [Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
Summary: [Chromium] WebKit::initialize should take a Platform* now that WebKitPlatform...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on: 110615
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-22 06:48 PST by Mark Pilgrim (Google)
Modified: 2013-02-23 11:58 PST (History)
7 users (show)

See Also:


Attachments
Patch (4.01 KB, patch)
2013-02-22 06:49 PST, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (4.16 KB, patch)
2013-02-23 08:51 PST, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2013-02-22 06:48:07 PST
[Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
Comment 1 Mark Pilgrim (Google) 2013-02-22 06:49:00 PST
Created attachment 189767 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-22 07:51:33 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Kentaro Hara 2013-02-22 08:37:00 PST
Comment on attachment 189767 [details]
Patch

pilgrim: oops, would you set r? again to wait for API reviewers?
Comment 4 WebKit Review Bot 2013-02-22 08:43:09 PST
Comment on attachment 189767 [details]
Patch

Clearing flags on attachment: 189767

Committed r143734: <http://trac.webkit.org/changeset/143734>
Comment 5 WebKit Review Bot 2013-02-22 08:43:13 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2013-02-22 09:04:41 PST
Re-opened since this is blocked by bug 110615
Comment 7 Mark Pilgrim (Google) 2013-02-23 08:51:37 PST
Created attachment 189927 [details]
Patch
Comment 8 Mark Pilgrim (Google) 2013-02-23 08:54:21 PST
Comment on attachment 189927 [details]
Patch

This patch fixes the downstream compilation issue by explicitly including Platform.h so other files that include WebKit.h know that WebKitPlatformSupport inherits from Platform class.
Comment 9 WebKit Review Bot 2013-02-23 11:58:53 PST
Comment on attachment 189927 [details]
Patch

Clearing flags on attachment: 189927

Committed r143846: <http://trac.webkit.org/changeset/143846>
Comment 10 WebKit Review Bot 2013-02-23 11:58:57 PST
All reviewed patches have been landed.  Closing bug.