Bug 110599 - Web Inspector: Native Memory Instrumentation: replace String with const char* in MemoryObjectInfo
Summary: Web Inspector: Native Memory Instrumentation: replace String with const char*...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-22 05:39 PST by Ilya Tikhonovsky
Modified: 2013-02-25 05:39 PST (History)
16 users (show)

See Also:

Attachments
Patch (16.12 KB, patch)
2013-02-23 04:30 PST, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2013-02-22 05:39:12 PST 
It costs us additional allocation for StringImpl. 
It forced us to have separate header for MemoryObjectInfo and gives unnecessary complexity of the code.
Comment 1 Ilya Tikhonovsky 2013-02-23 04:30:02 PST 
Created attachment 189923 [details]
Patch
Comment 2 Yury Semikhatsky 2013-02-25 05:13:12 PST 
Comment on attachment 189923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189923&action=review

> Source/WebCore/inspector/HeapGraphSerializer.cpp:217
> +    length = length < 256 ? length : 256;

if (length > 256)
    length = 256;
Comment 3 Ilya Tikhonovsky 2013-02-25 05:39:33 PST 
Committed r143913: <http://trac.webkit.org/changeset/143913>