RESOLVED FIXED 110589
Add a scrollbar class for the new calendar picker 
https://bugs.webkit.org/show_bug.cgi?id=110589
Summary Add a scrollbar class for the new calendar picker
Keishi Hattori
Reported 2013-02-22 04:43:40 PST
Add a scrollbar class for the new calendar picker
Attachments
Patch (6.65 KB, patch)
2013-02-25 00:21 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (6.68 KB, patch)
2013-02-25 03:08 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2013-02-25 00:21:31 PST
Created attachment 190008 [details] Patch
Kent Tamura
Comment 2 2013-02-25 01:42:56 PST
Comment on attachment 190008 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190008&action=review > Source/WebCore/Resources/pagepopups/calendarPicker.js:1378 > + this.knob = createElement("div", ScrubbyScrollBar.ClassNameScrubbyScrollKnob); nit: I think we usually call it "thumb" in WebKit, not "knob". > Source/WebCore/Resources/pagepopups/calendarPicker.js:1522 > + if (this._knobPosition < 0) > + scrollAmount = -scrollAmount; > + scrollAmount = -scrollAmount; duplicated lines
Keishi Hattori
Comment 3 2013-02-25 03:08:59 PST
Created attachment 190025 [details] Patch
WebKit Review Bot
Comment 4 2013-02-25 05:21:59 PST
Comment on attachment 190025 [details] Patch Clearing flags on attachment: 190025 Committed r143911: <http://trac.webkit.org/changeset/143911>
WebKit Review Bot
Comment 5 2013-02-25 05:22:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.