Bug 110589 - Add a scrollbar class for the new calendar picker
Summary: Add a scrollbar class for the new calendar picker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks: 109439
  Show dependency tree / graph
 
Reported: 2013-02-22 04:43 PST by Keishi Hattori
Modified: 2013-02-25 05:22 PST (History)
2 users (show)

See Also:

Attachments
Patch (6.65 KB, patch)
2013-02-25 00:21 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (6.68 KB, patch)
2013-02-25 03:08 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2013-02-22 04:43:40 PST 
Add a scrollbar class for the new calendar picker
Comment 1 Keishi Hattori 2013-02-25 00:21:31 PST 
Created attachment 190008 [details]
Patch
Comment 2 Kent Tamura 2013-02-25 01:42:56 PST 
Comment on attachment 190008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190008&action=review

> Source/WebCore/Resources/pagepopups/calendarPicker.js:1378
> +    this.knob = createElement("div", ScrubbyScrollBar.ClassNameScrubbyScrollKnob);

nit: I think we usually call it "thumb" in WebKit, not "knob".

> Source/WebCore/Resources/pagepopups/calendarPicker.js:1522
> +    if (this._knobPosition < 0)
> +        scrollAmount = -scrollAmount;
> +        scrollAmount = -scrollAmount;

duplicated lines
Comment 3 Keishi Hattori 2013-02-25 03:08:59 PST 
Created attachment 190025 [details]
Patch
Comment 4 WebKit Review Bot 2013-02-25 05:21:59 PST 
Comment on attachment 190025 [details]
Patch

Clearing flags on attachment: 190025

Committed r143911: <http://trac.webkit.org/changeset/143911>
Comment 5 WebKit Review Bot 2013-02-25 05:22:02 PST 
All reviewed patches have been landed.  Closing bug.