Bug 110580 - [BlackBerry] PlatformBlackBerry.cmake: create thin AR archives
Summary: [BlackBerry] PlatformBlackBerry.cmake: create thin AR archives
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 111729
  Show dependency treegraph
 
Reported: 2013-02-22 02:21 PST by Alberto Garcia
Modified: 2013-03-11 10:10 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.48 KB, patch)
2013-02-22 02:22 PST, Alberto Garcia
no flags Details | Formatted Diff | Diff
thinar.diff (2.06 KB, patch)
2013-03-08 08:05 PST, Xan Lopez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-02-22 02:21:14 PST
Otherwise libwecore.a goes beyond the 4Gb file size limit and the link phase fails.
Comment 1 Alberto Garcia 2013-02-22 02:22:26 PST
Created attachment 189725 [details]
Patch
Comment 2 Xan Lopez 2013-03-08 08:05:54 PST
Created attachment 192230 [details]
thinar.diff
Comment 3 Ming Xie 2013-03-11 09:07:42 PDT
This is a great patch! I can confirm linking time and archive size both go down a lot.

Before:
-rw-r--r--  1 mxie  staff   3.7G  8 Mar 14:22 libwebcore.a

After:
-rw-rw-r-- 1 mxie mxie 8.3M Mar 11 11:58 libwebcore.a

Thanks!! :-)
Comment 4 Rob Buis 2013-03-11 10:04:18 PDT
Comment on attachment 192230 [details]
thinar.diff

Nice improvement.
Comment 5 WebKit Review Bot 2013-03-11 10:10:02 PDT
Comment on attachment 192230 [details]
thinar.diff

Clearing flags on attachment: 192230

Committed r145372: <http://trac.webkit.org/changeset/145372>
Comment 6 WebKit Review Bot 2013-03-11 10:10:07 PDT
All reviewed patches have been landed.  Closing bug.