Bug 110529 - Threaded HTML Parser fails fast/dom/Document/readystate.html
Summary: Threaded HTML Parser fails fast/dom/Document/readystate.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 106127
  Show dependency tree / graph
 
Reported: 2013-02-21 16:28 PST by Adam Barth
Modified: 2013-02-21 17:15 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.33 KB, patch)
2013-02-21 16:49 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (3.37 KB, patch)
2013-02-21 16:54 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2013-02-21 16:28:52 PST 
Reduction:

<body>
<iframe></iframe>
<script>
testRunner.dumpAsText();
var doc = frames[0].document;
doc.open();
doc.close();
console.log(doc.body);
</script>

This outputs "null" with the threaded parser and non-null without.
Comment 1 Eric Seidel (no email) 2013-02-21 16:30:59 PST 
Just have to make sure you pump at least once for the body to be created.  Presumably for this script created parser we are failing to pump during flush, etc.  We should have had code for this?
Comment 2 Adam Barth 2013-02-21 16:49:32 PST 
Created attachment 189638 [details]
Patch
Comment 3 Eric Seidel (no email) 2013-02-21 16:51:18 PST 
Comment on attachment 189638 [details]
Patch

You could have had it spit out "PASS" instead. :)  But LGTM.
Comment 4 Adam Barth 2013-02-21 16:51:48 PST 
Comment on attachment 189638 [details]
Patch

Alright
Comment 5 Adam Barth 2013-02-21 16:54:21 PST 
Created attachment 189640 [details]
Patch for landing
Comment 6 WebKit Review Bot 2013-02-21 17:15:12 PST 
Comment on attachment 189640 [details]
Patch for landing

Clearing flags on attachment: 189640

Committed r143670: <http://trac.webkit.org/changeset/143670>
Comment 7 WebKit Review Bot 2013-02-21 17:15:15 PST 
All reviewed patches have been landed.  Closing bug.