Bug 110513 - Roll ANGLE to r1833
Summary: Roll ANGLE to r1833
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zhenyao Mo
URL:
Keywords:
Depends on:
Blocks: 110629
  Show dependency treegraph
 
Reported: 2013-02-21 14:17 PST by Zhenyao Mo
Modified: 2013-02-22 11:44 PST (History)
15 users (show)

See Also:


Attachments
Patch (113.41 KB, patch)
2013-02-21 14:29 PST, Zhenyao Mo
no flags Details | Formatted Diff | Diff
Patch (113.12 KB, patch)
2013-02-21 15:23 PST, Zhenyao Mo
no flags Details | Formatted Diff | Diff
Patch (115.82 KB, patch)
2013-02-21 17:13 PST, Zhenyao Mo
kbr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zhenyao Mo 2013-02-21 14:17:40 PST
This roll includes a few webkit side downstream angle fixes (64-32 fix, uninitialized error fix), and also the support for EXT_draw_buffers

After the roll, the ANGLE in webkit should be exactly the same as the one in upstream, except ShaderLang.h, where the "KHR" is removed from the include path.
Comment 1 Zhenyao Mo 2013-02-21 14:29:47 PST
Created attachment 189603 [details]
Patch
Comment 2 Zhenyao Mo 2013-02-21 15:23:48 PST
Created attachment 189616 [details]
Patch
Comment 3 WebKit Review Bot 2013-02-21 15:27:00 PST
Attachment 189616 [details] did not pass style-queue:

Source/ThirdParty/ANGLE/src/compiler/glslang.h:11:  glslang_scan is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSL.h:16:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSL.h:16:  The parameter name "clampingStrategy" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/src/compiler/ShaderLang.cpp:24:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/ShaderLang.cpp:287:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/ShaderLang.cpp:330:  max_len is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/DetectDiscontinuity.cpp:28:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/DetectDiscontinuity.cpp:31:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
Source/ThirdParty/ANGLE/src/compiler/DetectDiscontinuity.cpp:32:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/DetectDiscontinuity.cpp:47:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/ParseHelper.cpp:496:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/ParseHelper.cpp:515:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/ParseHelper.cpp:1510:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSL.cpp:10:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/ShHandle.h:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/common/debug.cpp:13:  Alphabetical sorting problem.  [build/include_order] [4]
Source/ThirdParty/ANGLE/src/compiler/SymbolTable.h:326:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/SymbolTable.h:326:  Extra space after ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/SymbolTable.h:326:  Missing space before {  [whitespace/braces] [5]
Source/ThirdParty/ANGLE/src/compiler/SymbolTable.h:328:  One space before end of line comments  [whitespace/comments] [5]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/Input.h:31:  One space before end of line comments  [whitespace/comments] [5]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/Input.h:32:  One space before end of line comments  [whitespace/comments] [5]
Source/ThirdParty/ANGLE/src/compiler/DetectDiscontinuity.h:26:  The parameter name "visit" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/src/compiler/DetectDiscontinuity.h:26:  The parameter name "loop" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/src/compiler/OutputHLSL.cpp:2569:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.h:20:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.h:20:  The parameter name "clampingStrategy" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/src/compiler/osinclude.h:47:  OS_TLSIndex is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/osinclude.h:47:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/ThirdParty/ANGLE/src/compiler/Compiler.cpp:105:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/Compiler.cpp:138:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/Preprocessor.h:11:  Alphabetical sorting problem.  [build/include_order] [4]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.cpp:43:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.cpp:50:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.cpp:228:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.cpp:230:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.cpp:250:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.cpp:252:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:824:  string_input is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:824:  max_size is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:1546:  More than one command on the same line  [whitespace/newline] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:1550:  More than one command on the same line  [whitespace/newline] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:1558:  More than one command on the same line  [whitespace/newline] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:2951:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:2951:  string_input is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:2951:  max_size is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:3020:  glslang_scan is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/Tokenizer.cpp:1129:  More than one command on the same line  [whitespace/newline] [4]
Source/ThirdParty/ANGLE/src/compiler/OutputESSL.cpp:10:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/common/system.h:9:  #ifndef header guard has wrong style, please use: system_h  [build/header_guard] [5]
Source/ThirdParty/ANGLE/src/common/system.h:16:  Alphabetical sorting problem.  [build/include_order] [4]
Source/ThirdParty/ANGLE/src/common/system.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
Source/ThirdParty/ANGLE/src/common/system.h:30:  One space before end of line comments  [whitespace/comments] [5]
Source/ThirdParty/ANGLE/src/compiler/OutputESSL.h:16:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/OutputESSL.h:16:  The parameter name "clampingStrategy" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/src/compiler/glslang_tab.cpp:761:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/glslang_tab.cpp:3177:  Extra space after ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:157:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:158:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:158:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:159:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:159:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:160:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:160:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:161:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:161:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:162:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:162:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:163:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:163:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:164:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:164:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:165:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:165:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:166:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:166:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:167:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:167:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:168:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:258:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:261:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:265:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:346:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:346:  yyss_alloc is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:347:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:347:  yyvs_alloc is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:382:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:386:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:386:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:387:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:476:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:477:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:478:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:815:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:818:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:819:  Declaration has space between type name and * in yytype_int16 *yybottom  [whitespace/declaration] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:820:  Declaration has space between type name and * in yytype_int16 *yytop  [whitespace/declaration] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:824:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:825:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:826:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:827:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:827:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:863:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:863:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:867:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:867:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1217:  Declaration has space between type name and * in yytype_int16 *yyss  [whitespace/declaration] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1218:  Declaration has space between type name and * in yytype_int16 *yyssp  [whitespace/declaration] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1222:  Declaration has space between type name and * in YYSTYPE *yyvs  [whitespace/declaration] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1223:  Declaration has space between type name and * in YYSTYPE *yyvsp  [whitespace/declaration] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1227:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1228:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1230:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1237:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1238:  Declaration has space between type name and * in char *yymsg  [whitespace/declaration] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1238:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1239:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1239:  yymsg_alloc is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1248:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1249:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1250:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1251:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1258:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1322:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1322:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1323:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1323:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1343:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1404:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1817:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:28:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:31:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:33:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:47:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:48:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:50:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:51:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:52:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:53:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:53:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:54:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:55:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:56:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:56:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:57:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:58:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:59:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:60:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:61:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:62:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:70:  One space before end of line comments  [whitespace/comments] [5]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:90:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:98:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:102:  This { should be at Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj', u'Source/ThirdParty/ANGLE/ChangeLog', u'Source/ThirdParty/ANGLE/Target.pri', u'Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h', u'Source/ThirdParty/ANGLE/src/common/debug.cpp', u'Source/ThirdParty/ANGLE/src/common/system.h', u'Source/ThirdParty/ANGLE/src/common/version.h', u'Source/ThirdParty/ANGLE/src/compiler/ArrayBoundsClamper.cpp', u'Source/ThirdParty/ANGLE/src/compiler/ArrayBoundsClamper.h', u'Source/ThirdParty/ANGLE/src/compiler/Compiler.cpp', u'Source/ThirdParty/ANGLE/src/compiler/DetectDiscontinuity.cpp', u'Source/ThirdParty/ANGLE/src/compiler/DetectDiscontinuity.h', u'Source/ThirdParty/ANGLE/src/compiler/Initialize.cpp', u'Source/ThirdParty/ANGLE/src/compiler/Intermediate.cpp', u'Source/ThirdParty/ANGLE/src/compiler/MapLongVariableNames.cpp', u'Source/ThirdParty/ANGLE/src/compiler/MapLongVariableNames.h', u'Source/ThirdParty/ANGLE/src/compiler/OutputESSL.cpp', u'Source/ThirdParty/ANGLE/src/compiler/OutputESSL.h', u'Source/ThirdParty/ANGLE/src/compiler/OutputGLSL.cpp', u'Source/ThirdParty/ANGLE/src/compiler/OutputGLSL.h', u'Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.cpp', u'Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.h', u'Source/ThirdParty/ANGLE/src/compiler/OutputHLSL.cpp', u'Source/ThirdParty/ANGLE/src/compiler/ParseHelper.cpp', u'Source/ThirdParty/ANGLE/src/compiler/ParseHelper.h', u'Source/ThirdParty/ANGLE/src/compiler/ShHandle.h', u'Source/ThirdParty/ANGLE/src/compiler/ShaderLang.cpp', u'Source/ThirdParty/ANGLE/src/compiler/SymbolTable.h', u'Source/ThirdParty/ANGLE/src/compiler/TranslatorESSL.cpp', u'Source/ThirdParty/ANGLE/src/compiler/TranslatorGLSL.cpp', u'Source/ThirdParty/ANGLE/src/compiler/ValidateLimitations.cpp', u'Source/ThirdParty/ANGLE/src/compiler/VariablePacker.cpp', u'Source/ThirdParty/ANGLE/src/compiler/glslang.h', u'Source/ThirdParty/ANGLE/src/compiler/glslang.l', u'Source/ThirdParty/ANGLE/src/compiler/glslang.y', u'Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp', u'Source/ThirdParty/ANGLE/src/compiler/glslang_tab.cpp', u'Source/ThirdParty/ANGLE/src/compiler/osinclude.h', u'Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp', u'Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.y', u'Source/ThirdParty/ANGLE/src/compiler/preprocessor/Input.cpp', u'Source/ThirdParty/ANGLE/src/compiler/preprocessor/Input.h', u'Source/ThirdParty/ANGLE/src/compiler/preprocessor/Preprocessor.cpp', u'Source/ThirdParty/ANGLE/src/compiler/preprocessor/Preprocessor.h', u'Source/ThirdParty/ANGLE/src/compiler/preprocessor/Tokenizer.cpp', u'Source/ThirdParty/ANGLE/src/compiler/preprocessor/Tokenizer.h', u'Source/ThirdParty/ANGLE/src/compiler/preprocessor/Tokenizer.l', u'Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp', u'Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.h', u'Source/ThirdParty/ANGLE/src/third_party/compiler/LICENSE', u'Source/ThirdParty/ANGLE/src/third_party/compiler/README.angle']" exit_code: 1
the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.h:26:  #ifndef header guard has wrong style, please use: ArrayBoundsClamper_h  [build/header_guard] [5]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.h:40:  The parameter name "clampingStrategy" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:159:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:160:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:161:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:167:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:168:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:170:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:171:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:211:  EXT_draw_buffers is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:316:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:359:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 167 in 49 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Build Bot 2013-02-21 15:37:58 PST
Comment on attachment 189616 [details]
Patch

Attachment 189616 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16698360
Comment 5 Kenneth Russell 2013-02-21 15:46:13 PST
Comment on attachment 189616 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189616&action=review

> Source/ThirdParty/ANGLE/src/compiler/osinclude.h:48
> +#define OS_INVALID_TLS_INDEX 0xFFFFFFFF

Sorry, I forgot to upstream this patch into ANGLE. Could you revert this change here and upstream it separately?
Comment 6 Early Warning System Bot 2013-02-21 15:47:09 PST
Comment on attachment 189616 [details]
Patch

Attachment 189616 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16699349
Comment 7 Early Warning System Bot 2013-02-21 15:53:59 PST
Comment on attachment 189616 [details]
Patch

Attachment 189616 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16671023
Comment 8 Kenneth Russell 2013-02-21 15:57:32 PST
Comment on attachment 189616 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189616&action=review

>> Source/ThirdParty/ANGLE/src/compiler/OutputHLSL.cpp:2569
>> +              case EbtFloat: out << std::min(FLT_MAX, std::max(-FLT_MAX, constUnion->getFConst())); break;
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

It looks like the reference to FLT_MAX may need to be updated somehow...
Comment 9 EFL EWS Bot 2013-02-21 16:42:12 PST
Comment on attachment 189616 [details]
Patch

Attachment 189616 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16690439
Comment 10 Zhenyao Mo 2013-02-21 17:13:16 PST
Created attachment 189643 [details]
Patch
Comment 11 WebKit Review Bot 2013-02-21 17:16:29 PST
Attachment 189643 [details] did not pass style-queue:

Source/ThirdParty/ANGLE/src/compiler/glslang.h:11:  glslang_scan is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSL.h:16:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSL.h:16:  The parameter name "clampingStrategy" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/src/compiler/ShaderLang.cpp:24:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/ShaderLang.cpp:287:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/ShaderLang.cpp:330:  max_len is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/DetectDiscontinuity.cpp:28:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/DetectDiscontinuity.cpp:31:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
Source/ThirdParty/ANGLE/src/compiler/DetectDiscontinuity.cpp:32:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/DetectDiscontinuity.cpp:47:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/ParseHelper.cpp:496:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/ParseHelper.cpp:515:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/ParseHelper.cpp:1510:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSL.cpp:10:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/ShHandle.h:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/common/debug.cpp:13:  Alphabetical sorting problem.  [build/include_order] [4]
Source/ThirdParty/ANGLE/src/compiler/SymbolTable.h:326:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/SymbolTable.h:326:  Extra space after ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/SymbolTable.h:326:  Missing space before {  [whitespace/braces] [5]
Source/ThirdParty/ANGLE/src/compiler/SymbolTable.h:328:  One space before end of line comments  [whitespace/comments] [5]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/Input.h:31:  One space before end of line comments  [whitespace/comments] [5]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/Input.h:32:  One space before end of line comments  [whitespace/comments] [5]
Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:824:  string_input is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:824:  max_size is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:1546:  More than one command on the same line  [whitespace/newline] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:1550:  More than one command on the same line  [whitespace/newline] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:1558:  More than one command on the same line  [whitespace/newline] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:2951:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:2951:  string_input is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:2951:  max_size is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:3020:  glslang_scan is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/DetectDiscontinuity.h:26:  The parameter name "visit" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/src/compiler/DetectDiscontinuity.h:26:  The parameter name "loop" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/src/compiler/OutputHLSL.cpp:11:  Alphabetical sorting problem.  [build/include_order] [4]
Source/ThirdParty/ANGLE/src/compiler/OutputHLSL.cpp:2569:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.h:20:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.h:20:  The parameter name "clampingStrategy" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/Preprocessor.h:11:  Alphabetical sorting problem.  [build/include_order] [4]
Source/ThirdParty/ANGLE/src/compiler/Compiler.cpp:105:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/Compiler.cpp:138:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.cpp:43:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.cpp:50:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.cpp:228:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.cpp:230:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.cpp:250:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.cpp:252:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/Tokenizer.cpp:1129:  More than one command on the same line  [whitespace/newline] [4]
Source/ThirdParty/ANGLE/src/compiler/OutputESSL.cpp:10:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/common/system.h:9:  #ifndef header guard has wrong style, please use: system_h  [build/header_guard] [5]
Source/ThirdParty/ANGLE/src/common/system.h:16:  Alphabetical sorting problem.  [build/include_order] [4]
Source/ThirdParty/ANGLE/src/common/system.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
Source/ThirdParty/ANGLE/src/common/system.h:30:  One space before end of line comments  [whitespace/comments] [5]
Source/ThirdParty/ANGLE/src/compiler/OutputESSL.h:16:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/OutputESSL.h:16:  The parameter name "clampingStrategy" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/src/compiler/glslang_tab.cpp:761:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/glslang_tab.cpp:3177:  Extra space after ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:157:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:158:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:158:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:159:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:159:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:160:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:160:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:161:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:161:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:162:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:162:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:163:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:163:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:164:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:164:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:165:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:165:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:166:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:166:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:167:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:167:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:168:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:258:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:261:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:265:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:346:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:346:  yyss_alloc is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:347:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:347:  yyvs_alloc is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:382:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:386:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:386:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:387:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:476:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:477:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:478:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:815:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:818:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:819:  Declaration has space between type name and * in yytype_int16 *yybottom  [whitespace/declaration] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:820:  Declaration has space between type name and * in yytype_int16 *yytop  [whitespace/declaration] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:824:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:825:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:826:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:827:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:827:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:863:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:863:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:867:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:867:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1217:  Declaration has space between type name and * in yytype_int16 *yyss  [whitespace/declaration] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1218:  Declaration has space between type name and * in yytype_int16 *yyssp  [whitespace/declaration] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1222:  Declaration has space between type name and * in YYSTYPE *yyvs  [whitespace/declaration] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1223:  Declaration has space between type name and * in YYSTYPE *yyvsp  [whitespace/declaration] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1227:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1228:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1230:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1237:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1238:  Declaration has space between type name and * in char *yymsg  [whitespace/declaration] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1238:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1239:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1239:  yymsg_alloc is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1248:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1249:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1250:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1251:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1258:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1322:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1322:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1323:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1323:  Extra space before ( in function call  [whitespace/parens] [4]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1343:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1404:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:1817:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:28:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:31:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:33:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:47:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:48:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:50:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:51:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:52:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:53:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:53:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:54:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:55:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:56:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:56:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:57:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:58:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:59:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:60:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:61:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:62:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:70:  One space before end of line comments  [whitespace/comments] [5]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:90:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:98:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp:102:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.h:26:  #ifndef header guard has wrong style, Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj', u'Source/ThirdParty/ANGLE/ChangeLog', u'Source/ThirdParty/ANGLE/Target.pri', u'Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h', u'Source/ThirdParty/ANGLE/src/common/debug.cpp', u'Source/ThirdParty/ANGLE/src/common/system.h', u'Source/ThirdParty/ANGLE/src/common/version.h', u'Source/ThirdParty/ANGLE/src/compiler/ArrayBoundsClamper.cpp', u'Source/ThirdParty/ANGLE/src/compiler/ArrayBoundsClamper.h', u'Source/ThirdParty/ANGLE/src/compiler/Compiler.cpp', u'Source/ThirdParty/ANGLE/src/compiler/DetectDiscontinuity.cpp', u'Source/ThirdParty/ANGLE/src/compiler/DetectDiscontinuity.h', u'Source/ThirdParty/ANGLE/src/compiler/Initialize.cpp', u'Source/ThirdParty/ANGLE/src/compiler/Intermediate.cpp', u'Source/ThirdParty/ANGLE/src/compiler/MapLongVariableNames.cpp', u'Source/ThirdParty/ANGLE/src/compiler/MapLongVariableNames.h', u'Source/ThirdParty/ANGLE/src/compiler/OutputESSL.cpp', u'Source/ThirdParty/ANGLE/src/compiler/OutputESSL.h', u'Source/ThirdParty/ANGLE/src/compiler/OutputGLSL.cpp', u'Source/ThirdParty/ANGLE/src/compiler/OutputGLSL.h', u'Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.cpp', u'Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.h', u'Source/ThirdParty/ANGLE/src/compiler/OutputHLSL.cpp', u'Source/ThirdParty/ANGLE/src/compiler/ParseHelper.cpp', u'Source/ThirdParty/ANGLE/src/compiler/ParseHelper.h', u'Source/ThirdParty/ANGLE/src/compiler/ShHandle.h', u'Source/ThirdParty/ANGLE/src/compiler/ShaderLang.cpp', u'Source/ThirdParty/ANGLE/src/compiler/SymbolTable.h', u'Source/ThirdParty/ANGLE/src/compiler/TranslatorESSL.cpp', u'Source/ThirdParty/ANGLE/src/compiler/TranslatorGLSL.cpp', u'Source/ThirdParty/ANGLE/src/compiler/ValidateLimitations.cpp', u'Source/ThirdParty/ANGLE/src/compiler/VariablePacker.cpp', u'Source/ThirdParty/ANGLE/src/compiler/glslang.h', u'Source/ThirdParty/ANGLE/src/compiler/glslang.l', u'Source/ThirdParty/ANGLE/src/compiler/glslang.y', u'Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp', u'Source/ThirdParty/ANGLE/src/compiler/glslang_tab.cpp', u'Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp', u'Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.y', u'Source/ThirdParty/ANGLE/src/compiler/preprocessor/Input.cpp', u'Source/ThirdParty/ANGLE/src/compiler/preprocessor/Input.h', u'Source/ThirdParty/ANGLE/src/compiler/preprocessor/Preprocessor.cpp', u'Source/ThirdParty/ANGLE/src/compiler/preprocessor/Preprocessor.h', u'Source/ThirdParty/ANGLE/src/compiler/preprocessor/Tokenizer.cpp', u'Source/ThirdParty/ANGLE/src/compiler/preprocessor/Tokenizer.h', u'Source/ThirdParty/ANGLE/src/compiler/preprocessor/Tokenizer.l', u'Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp', u'Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.h', u'Source/ThirdParty/ANGLE/src/third_party/compiler/LICENSE', u'Source/ThirdParty/ANGLE/src/third_party/compiler/README.angle', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am']" exit_code: 1
please use: ArrayBoundsClamper_h  [build/header_guard] [5]
Source/ThirdParty/ANGLE/src/third_party/compiler/ArrayBoundsClamper.h:40:  The parameter name "clampingStrategy" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:159:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:160:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:161:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:167:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:168:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:170:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:171:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:211:  EXT_draw_buffers is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:316:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:359:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 166 in 51 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Zhenyao Mo 2013-02-21 17:18:55 PST
Ken: this one should work (finally!!!).  Please have a look.
Comment 13 Kenneth Russell 2013-02-21 19:42:13 PST
Comment on attachment 189643 [details]
Patch

Very nice work. r=me
Comment 14 Zhenyao Mo 2013-02-22 09:44:20 PST
Committed r143742: <http://trac.webkit.org/changeset/143742>