Bug 110494 - Disable MediaSource on Apple Windows port
Summary: Disable MediaSource on Apple Windows port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aaron Colwell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-21 11:23 PST by Aaron Colwell
Modified: 2013-02-22 18:00 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2013-02-21 11:25 PST, Aaron Colwell 		no flags Details | Formatted Diff | Diff
Patch (1.44 KB, patch)
2013-02-21 12:23 PST, Aaron Colwell 		no flags Details | Formatted Diff | Diff
Removed newline at end of file. (1.28 KB, patch)
2013-02-21 13:18 PST, Aaron Colwell 		no flags Details | Formatted Diff | Diff
VS 2005 & 2010 fixes (2.12 KB, patch)
2013-02-22 15:15 PST, Aaron Colwell 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Colwell 2013-02-21 11:23:45 PST 
While working on Bug 109857, I discovered that the MediaSource code was getting built for Apple's Windows port. I'm pretty sure this was an accident since there doesn't appear to be any other MediaSource specific code for this port.
Comment 1 Aaron Colwell 2013-02-21 11:25:35 PST 
Created attachment 189563 [details]
Patch
Comment 2 Aaron Colwell 2013-02-21 12:23:16 PST 
Created attachment 189575 [details]
Patch
Comment 3 Aaron Colwell 2013-02-21 13:18:01 PST 
Created attachment 189588 [details]
Removed newline at end of file.
Comment 4 Roger Fong 2013-02-22 14:42:02 PST 
Instead of getting rid of the whole ENABLE_MEDIA_SOURCE line can you just get rid of the contents in the tag?

Also this is only for the VS2010 solution. 
We actually are running the VS2005 solution on all the bots.
The FeaturesDefines in WebKitLibraries/win/tools/vsprops also needs to be modified appropriately.

Thanks!
Comment 5 Aaron Colwell 2013-02-22 15:15:39 PST 
Created attachment 189844 [details]
VS 2005 & 2010 fixes
Comment 6 Roger Fong 2013-02-22 15:30:22 PST 
Looks good to me although I don't have review yet. CC'ing Brent who does.
The vsprops files sometimes complain about not being able to commit when they should be able to. 
Feel free to force commit it if need be.
Comment 7 Aaron Colwell 2013-02-22 17:44:11 PST 
Brent, Can I get a review on this please. This is preventing me from landing other changes. Thanks.
Comment 8 Tim Horton 2013-02-22 17:48:42 PST 
Comment on attachment 189844 [details]
VS 2005 & 2010 fixes

View in context: https://bugs.webkit.org/attachment.cgi?id=189844&action=review

> WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:266
> -		Value="ENABLE_MEDIA_SOURCE"
> +		Value=""

Wut.
Comment 9 Tim Horton 2013-02-22 17:49:04 PST 
(In reply to comment #8)
> (From update of attachment 189844 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=189844&action=review
> 
> > WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:266
> > -		Value="ENABLE_MEDIA_SOURCE"
> > +		Value=""
> 
> Wut.

Oh, it looks fine here. It looked really weird in the review thing.
Comment 10 Aaron Colwell 2013-02-22 17:53:13 PST 
(In reply to comment #9)
> (In reply to comment #8)
> > (From update of attachment 189844 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=189844&action=review
> > 
> > > WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:266
> > > -		Value="ENABLE_MEDIA_SOURCE"
> > > +		Value=""
> > 
> > Wut.
> 
> Oh, it looks fine here. It looked really weird in the review thing.

Thanks for the review.
Comment 11 WebKit Review Bot 2013-02-22 18:00:48 PST 
Comment on attachment 189844 [details]
VS 2005 & 2010 fixes

Clearing flags on attachment: 189844

Committed r143822: <http://trac.webkit.org/changeset/143822>
Comment 12 WebKit Review Bot 2013-02-22 18:00:53 PST 
All reviewed patches have been landed.  Closing bug.