Bug 110494 – Disable MediaSource on Apple Windows port

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Aaron Colwell]

While working on Bug 109857, I discovered that the MediaSource code was getting built for Apple's Windows port. I'm pretty sure this was an accident since there doesn't appear to be any other MediaSource specific code for this port.

[Aaron Colwell]

Created attachment 189563 [details]
Patch

[Aaron Colwell]

Created attachment 189575 [details]
Patch

[Aaron Colwell]

Created attachment 189588 [details]
Removed newline at end of file.

[Roger Fong]

Instead of getting rid of the whole ENABLE_MEDIA_SOURCE line can you just get rid of the contents in the tag?

Also this is only for the VS2010 solution. 
We actually are running the VS2005 solution on all the bots.
The FeaturesDefines in WebKitLibraries/win/tools/vsprops also needs to be modified appropriately.

Thanks!

[Aaron Colwell]

Created attachment 189844 [details]
VS 2005 & 2010 fixes

[Roger Fong]

Looks good to me although I don't have review yet. CC'ing Brent who does.
The vsprops files sometimes complain about not being able to commit when they should be able to. 
Feel free to force commit it if need be.

[Aaron Colwell]

Brent, Can I get a review on this please. This is preventing me from landing other changes. Thanks.

[Tim Horton]

Comment on attachment 189844 [details]
VS 2005 & 2010 fixes

View in context: https://bugs.webkit.org/attachment.cgi?id=189844&action=review

> WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:266
> -		Value="ENABLE_MEDIA_SOURCE"
> +		Value=""

Wut.

[Tim Horton]

(In reply to comment #8)
> (From update of attachment 189844 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=189844&action=review
> 
> > WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:266
> > -		Value="ENABLE_MEDIA_SOURCE"
> > +		Value=""
> 
> Wut.

Oh, it looks fine here. It looked really weird in the review thing.

[Aaron Colwell]

(In reply to comment #9)
> (In reply to comment #8)
> > (From update of attachment 189844 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=189844&action=review
> > 
> > > WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:266
> > > -		Value="ENABLE_MEDIA_SOURCE"
> > > +		Value=""
> > 
> > Wut.
> 
> Oh, it looks fine here. It looked really weird in the review thing.

Thanks for the review.

[WebKit Review Bot]

Comment on attachment 189844 [details]
VS 2005 & 2010 fixes

Clearing flags on attachment: 189844

Committed r143822: <http://trac.webkit.org/changeset/143822>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.