Bug 110488 - Work around a MSVC 2012 Update 1 bug causing a crash on x86
Summary: Work around a MSVC 2012 Update 1 bug causing a crash on x86
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-21 09:58 PST by Jocelyn Turcotte
Modified: 2013-02-26 05:03 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2013-02-21 10:00 PST, Jocelyn Turcotte 		andersca: review-
Details | Formatted Diff | Diff
Patch (2.24 KB, patch)
2013-02-25 08:11 PST, Jocelyn Turcotte 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2013-02-21 09:58:28 PST 
Work around a MSVC 2012 Update 1 bug causing a crash on x86
Comment 1 Jocelyn Turcotte 2013-02-21 10:00:26 PST 
Created attachment 189548 [details]
Patch
Comment 2 Anders Carlsson 2013-02-22 11:02:57 PST 
Comment on attachment 189548 [details]
Patch

This absolutely needs a comment. Also, I think it should be surrounded in an #ifdef so that we can remove it eventually.
Comment 3 Jocelyn Turcotte 2013-02-25 08:11:00 PST 
Created attachment 190063 [details]
Patch

Added the ifdef as well since the comment alone would lack context.
Comment 4 Anders Carlsson 2013-02-25 09:10:42 PST 
Comment on attachment 190063 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190063&action=review

> Source/WebCore/platform/text/TextEncodingRegistry.cpp:73
> +            if (c1 != c2)

I think you should put a return false inside the #ifdef.

> Source/WebCore/platform/text/TextEncodingRegistry.cpp:78
> +#endif

And then extend the ifdef below the return false; line.
Comment 5 Jocelyn Turcotte 2013-02-26 05:03:59 PST 
Committed r144042: <http://trac.webkit.org/changeset/144042>