Bug 110481 - [Chromium] Disable registerProtocolHandler on Android
Summary: [Chromium] Disable registerProtocolHandler on Android
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anton Vayvod
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2013-02-21 08:51 PST by Anton Vayvod
Modified: 2013-02-25 06:08 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.95 KB, patch)
2013-02-21 08:55 PST, Anton Vayvod 		no flags Details | Formatted Diff | Diff
Patch (2.95 KB, patch)
2013-02-21 09:10 PST, Anton Vayvod 		no flags Details | Formatted Diff | Diff
Patch (3.03 KB, patch)
2013-02-25 04:06 PST, Anton Vayvod 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Vayvod 2013-02-21 08:51:17 PST 
[Chromium] Disable registerProtocolHandler on Android
Comment 1 Anton Vayvod 2013-02-21 08:55:40 PST 
Created attachment 189540 [details]
Patch
Comment 2 Anton Vayvod 2013-02-21 08:57:27 PST 
Julien, since you reviewed the first attempt, could you take a look, please?
Comment 3 Anton Vayvod 2013-02-21 09:10:33 PST 
Created attachment 189545 [details]
Patch
Comment 4 Julien Chaffraix 2013-02-22 12:46:48 PST 
Comment on attachment 189545 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189545&action=review

r=me, but the ChangeLog should be amended before landing.

> Source/WebKit/chromium/ChangeLog:12
> +

You should mention the *why* which the original change properly explained: this is done because Android doesn't wire the implementation and you don't want to break feature detection. crbug.com/156386 should also be mentioned as it properly highlight the challenges of implementing it in Android.
Comment 5 Anton Vayvod 2013-02-25 04:06:39 PST 
Created attachment 190029 [details]
Patch
Comment 6 Peter Beverloo 2013-02-25 04:19:54 PST 
Comment on attachment 190029 [details]
Patch

Thank you for the explanation! SGTM.
Comment 7 WebKit Review Bot 2013-02-25 06:08:36 PST 
Comment on attachment 190029 [details]
Patch

Clearing flags on attachment: 190029

Committed r143917: <http://trac.webkit.org/changeset/143917>
Comment 8 WebKit Review Bot 2013-02-25 06:08:41 PST 
All reviewed patches have been landed.  Closing bug.