Bug 110477 - [New Multicolumn] Remove unneeded layout method in RenderMultiColumnFlowThread
Summary: [New Multicolumn] Remove unneeded layout method in RenderMultiColumnFlowThread
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-21 08:29 PST by Dave Hyatt
Modified: 2013-02-21 08:34 PST (History)
0 users

See Also:

Attachments
Patch (2.62 KB, patch)
2013-02-21 08:30 PST, Dave Hyatt 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2013-02-21 08:29:02 PST 
I forgot that both the sets and the flow thread lay out before the containing RenderMultiColumnBlock has finished. That means it hasn't computed its overflow yet. Therefore there is no need to force it to compute its overflow from inside RenderMultiColumnFlowThread::layout, because the minute RenderMultiColumnFlowThread finishes its layout, the block will compute its overflow anyway.
Comment 1 Dave Hyatt 2013-02-21 08:30:16 PST 
Created attachment 189537 [details]
Patch
Comment 2 Dave Hyatt 2013-02-21 08:34:54 PST 
Fixed in r143606.