Bug 110466 – Web Inspector: Remove CPU profile from a group causes exception

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexei Filippov]

To reproduce collect several CPU profiles with the same name, e.g.:
console.profile("alph");
console.profileEnd("alph");
console.profile("alph");
console.profileEnd("alph");

and try to remove these profiles one-by-one from UI. An exception is raised.

[Alexei Filippov]

Created attachment 189533 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 189533 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189533&action=review

> Source/WebCore/inspector/front-end/ProfilesPanel.js:559
> +        if (!WebInspector.ProfilesPanelDescriptor.isUserInitiatedProfile(profile.title) && !profile.isTemporary) {

Why do we skip temporary profiles?

> LayoutTests/inspector/profiler/cpu-profiler-profile-removal.html:18
> +    InspectorTest.runProfilerTestSuite([

You don't need the suite since there is only one test.

> LayoutTests/inspector/profiler/cpu-profiler-profile-removal.html:24
> +                    profiles._removeProfileHeader(profiles._profiles[0]);

Can you check that the group and all profiles are actually removed from the profiles panel sidebar?

[Alexei Filippov]

Created attachment 189719 [details]
Patch

[Alexei Filippov]

Comment on attachment 189533 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189533&action=review

>> Source/WebCore/inspector/front-end/ProfilesPanel.js:559
>> +        if (!WebInspector.ProfilesPanelDescriptor.isUserInitiatedProfile(profile.title) && !profile.isTemporary) {
> 
> Why do we skip temporary profiles?

I don't want'em to form groups.

>> LayoutTests/inspector/profiler/cpu-profiler-profile-removal.html:18
>> +    InspectorTest.runProfilerTestSuite([
> 
> You don't need the suite since there is only one test.

I made it consistent to other tests, e.g. cpu-profiler-profiling.html
Well, removed the suite usage.

>> LayoutTests/inspector/profiler/cpu-profiler-profile-removal.html:24
>> +                    profiles._removeProfileHeader(profiles._profiles[0]);
> 
> Can you check that the group and all profiles are actually removed from the profiles panel sidebar?

_profiles should be empty because of the loop condition. Added a check for _profileGroups.

[Yury Semikhatsky]

(In reply to comment #4)
> (From update of attachment 189533 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=189533&action=review
> >> LayoutTests/inspector/profiler/cpu-profiler-profile-removal.html:24
> >> +                    profiles._removeProfileHeader(profiles._profiles[0]);
> > 
> > Can you check that the group and all profiles are actually removed from the profiles panel sidebar?
> 
> _profiles should be empty because of the loop condition. Added a check for _profileGroups.

I meant checking that there are no entries in the sidebar no in the profiles collection.

[WebKit Review Bot]

Comment on attachment 189719 [details]
Patch

Rejecting attachment 189719 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 189719, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:

fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2

Updating OpenSource
fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2
Updating OpenSource
fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Full output: http://queues.webkit.org/results/16694853

[Alexei Filippov]

Created attachment 190048 [details]
Patch

[WebKit Review Bot]

Comment on attachment 190048 [details]
Patch

Clearing flags on attachment: 190048

Committed r143923: <http://trac.webkit.org/changeset/143923>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.