Bug 110410 - Specify plug-in process / service entitlements via the Xcode configuration
Summary: Specify plug-in process / service entitlements via the Xcode configuration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-20 16:52 PST by Mark Rowe (bdash)
Modified: 2013-02-20 17:31 PST (History)
3 users (show)

See Also:


Attachments
Patch v1 (13.14 KB, patch)
2013-02-20 16:53 PST, Mark Rowe (bdash)
ap: review+
mrowe: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2013-02-20 16:52:57 PST
This is the modern mechanism for applying entitlements to production builds, and it simplifies the maintenance of entitlements going forward.
Comment 1 Mark Rowe (bdash) 2013-02-20 16:53:16 PST
Created attachment 189418 [details]
Patch v1
Comment 2 WebKit Review Bot 2013-02-20 16:57:29 PST
Attachment 189418 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Configurations/Base.xcconfig', u'Source/WebKit2/Configurations/PluginProcess.xcconfig', u'Source/WebKit2/Configurations/PluginService.32.xcconfig', u'Source/WebKit2/Configurations/PluginService.64.xcconfig', u'Source/WebKit2/Configurations/PluginService.Development.xcconfig', u'Source/WebKit2/Configurations/PluginService.entitlements', u'Source/WebKit2/PluginProcess/mac/PluginProcess.entitlements', u'Source/WebKit2/PluginProcess/mac/add-entitlements.sh', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Rowe (bdash) 2013-02-20 17:31:01 PST
Landed in r143544.