Bug 110409 - Clean up PluginService info plists
Summary: Clean up PluginService info plists
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-20 16:50 PST by Mark Rowe (bdash)
Modified: 2013-02-21 09:59 PST (History)
2 users (show)

See Also:

Attachments
Patch v1 (9.61 KB, patch)
2013-02-20 16:50 PST, Mark Rowe (bdash) 		no flags Details | Formatted Diff | Diff
Patch v2 (6.53 KB, patch)
2013-02-20 16:51 PST, Mark Rowe (bdash) 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2013-02-20 16:50:28 PST 
The 32- and 64-bit plists are virtually identical. They can share a single plist and rely on build setting expansion to fill in the differences.
Comment 1 Mark Rowe (bdash) 2013-02-20 16:50:56 PST 
Created attachment 189415 [details]
Patch v1
Comment 2 Mark Rowe (bdash) 2013-02-20 16:51:33 PST 
Created attachment 189417 [details]
Patch v2
Comment 3 WebKit Review Bot 2013-02-20 16:55:35 PST 
Attachment 189417 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Configurations/PluginService.32.xcconfig', u'Source/WebKit2/Configurations/PluginService.64.xcconfig', u'Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist', u'Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist', u'Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist']" exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Mark Rowe (bdash) 2013-02-20 17:30:53 PST 
Landed in r143543.