Bug 110403 – [BlackBerry] WebPagePrivate::load should not check new window policy

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Andrew Lo]

Based on my understanding of http://trac.webkit.org/changeset/135952, we should not check the new window policy in WebPagePrivate::load.
    
None of the other ports seem to do this, except for plugins.

[Andrew Lo]

Created attachment 189402 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 189402 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189402&action=review

> Source/WebKit/blackberry/Api/WebPage.cpp:744
>      FrameLoadRequest frameRequest(m_mainFrame, request);
> -    frameRequest.setFrameName("");
> -    frameRequest.setShouldCheckNewWindowPolicy(true);
>      m_mainFrame->loader()->load(frameRequest);

Now that we don't need the local variable maybe we could leave a single line 

m_mainFrame->loader()->load(FrameLoadRequest(m_mainFrame, request));

[Andrew Lo]

Created attachment 189552 [details]
Patch

[Rob Buis]

Comment on attachment 189552 [details]
Patch

Looks good.

[WebKit Review Bot]

Comment on attachment 189552 [details]
Patch

Rejecting attachment 189552 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 189552, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:

fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2

Updating OpenSource
fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2
Updating OpenSource
fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Full output: http://queues.webkit.org/results/16699164

[WebKit Review Bot]

Comment on attachment 189552 [details]
Patch

Clearing flags on attachment: 189552

Committed r143629: <http://trac.webkit.org/changeset/143629>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.