RESOLVED FIXED110399
LevelDB: Remove excess vector copy 
https://bugs.webkit.org/show_bug.cgi?id=110399
Summary LevelDB: Remove excess vector copy
Alec Flett
Reported 2013-02-20 15:55:49 PST
LevelDB: Remove excess vector copy
Attachments
Patch (1.90 KB, patch)
2013-02-20 15:56 PST, Alec Flett 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alec Flett
Comment 1 2013-02-20 15:56:51 PST
Created attachment 189398 [details] Patch
Alec Flett
Comment 2 2013-02-20 15:59:01 PST
tony@ - it looks like someone thought they were going to benefit from NRVO optimization, but that isn't possible because the return object is a reference that comes in via a parameter. Instead, we get an extra copy. I did a blame and looked back - this looks like it corresponds to the original checkin of LevelDBDatabase.cpp by hans@chromium.org so it doesn't look like this was any kind of purposefully optimization.
WebKit Review Bot
Comment 3 2013-02-20 16:51:40 PST
Comment on attachment 189398 [details] Patch Clearing flags on attachment: 189398 Committed r143538: <http://trac.webkit.org/changeset/143538>
WebKit Review Bot
Comment 4 2013-02-20 16:51:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.