RESOLVED FIXED 110382
Stop hardcoding knowledge about blob protocol in ResourceHandle 
https://bugs.webkit.org/show_bug.cgi?id=110382
Summary Stop hardcoding knowledge about blob protocol in ResourceHandle
Alexey Proskuryakov
Reported 2013-02-20 14:14:40 PST
We register protocols for asynchronous loading, but hardcode "blob" in synchronous code path.
Attachments
proposed patch (13.68 KB, patch)
2013-02-20 16:27 PST, Alexey Proskuryakov 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
with build fixes (13.65 KB, patch)
2013-02-20 16:42 PST, Alexey Proskuryakov 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-02-20 16:27:01 PST
Created attachment 189406 [details] proposed patch
WebKit Review Bot
Comment 2 2013-02-20 16:28:34 PST
Attachment 189406 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/BlobRegistry.h', u'Source/WebCore/platform/network/BlobRegistryImpl.cpp', u'Source/WebCore/platform/network/BlobRegistryImpl.h', u'Source/WebCore/platform/network/BlobResourceHandle.cpp', u'Source/WebCore/platform/network/BlobResourceHandle.h', u'Source/WebCore/platform/network/ResourceHandle.cpp', u'Source/WebCore/platform/network/ResourceHandle.h', u'Source/WebCore/platform/network/chromium/BlobRegistryProxy.h']" exit_code: 1 Source/WebCore/platform/network/BlobResourceHandle.cpp:73: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2013-02-20 16:33:28 PST
Comment on attachment 189406 [details] proposed patch Attachment 189406 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16647628
EFL EWS Bot
Comment 4 2013-02-20 16:36:16 PST
Comment on attachment 189406 [details] proposed patch Attachment 189406 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16650628
Early Warning System Bot
Comment 5 2013-02-20 16:37:09 PST
Comment on attachment 189406 [details] proposed patch Attachment 189406 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16653619
Alexey Proskuryakov
Comment 6 2013-02-20 16:42:20 PST
Created attachment 189413 [details] with build fixes
WebKit Review Bot
Comment 7 2013-02-20 16:44:07 PST
Attachment 189413 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/BlobRegistry.h', u'Source/WebCore/platform/network/BlobRegistryImpl.cpp', u'Source/WebCore/platform/network/BlobRegistryImpl.h', u'Source/WebCore/platform/network/BlobResourceHandle.cpp', u'Source/WebCore/platform/network/BlobResourceHandle.h', u'Source/WebCore/platform/network/ResourceHandle.cpp', u'Source/WebCore/platform/network/ResourceHandle.h', u'Source/WebCore/platform/network/chromium/BlobRegistryProxy.h']" exit_code: 1 Source/WebCore/platform/network/BlobResourceHandle.cpp:73: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 8 2013-02-21 00:29:32 PST
Committed <http://trac.webkit.org/r143569>.
Note You need to log in before you can comment on or make changes to this bug.