Bug 110381 - Line layout (but not pref widths) double-counts word spacing when between inlines
Summary: Line layout (but not pref widths) double-counts word spacing when between inl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL: https://code.google.com/p/chromium/is...
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-20 14:14 PST by Levi Weintraub
Modified: 2013-02-20 15:46 PST (History)
7 users (show)

See Also:


Attachments
Patch (4.57 KB, patch)
2013-02-20 14:27 PST, Levi Weintraub
no flags Details | Formatted Diff | Diff
Patch (5.27 KB, patch)
2013-02-20 14:47 PST, Levi Weintraub
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2013-02-20 14:14:26 PST
We correctly determine the preferred logical width for a line with word-spacing set and spaces between inlines, but when laying out the line, we add word spacing an extra time which leads to wrapping inline-blocks.

Example: http://codepen.io/jeremychurch/pen/BFLbi
Comment 1 Levi Weintraub 2013-02-20 14:27:36 PST
Created attachment 189380 [details]
Patch
Comment 2 Emil A Eklund 2013-02-20 14:32:01 PST
Comment on attachment 189380 [details]
Patch

Is the bug limited to floats or does it also apply to inline-block elements? If so could you please add a line of inline-blocks to the test?
Comment 3 Levi Weintraub 2013-02-20 14:47:11 PST
Created attachment 189383 [details]
Patch
Comment 4 WebKit Review Bot 2013-02-20 15:46:04 PST
Comment on attachment 189383 [details]
Patch

Clearing flags on attachment: 189383

Committed r143520: <http://trac.webkit.org/changeset/143520>
Comment 5 WebKit Review Bot 2013-02-20 15:46:08 PST
All reviewed patches have been landed.  Closing bug.