WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
110374
Accept 'allowfullscreen' in addition to 'webkitallowfullscreen'.
https://bugs.webkit.org/show_bug.cgi?id=110374
Summary
Accept 'allowfullscreen' in addition to 'webkitallowfullscreen'.
Vincent Scheib
Reported
2013-02-20 13:27:45 PST
Accept 'allowfullscreen' in addition to 'webkitallowfullscreen'.
Attachments
Patch
(13.37 KB, patch)
2013-02-20 13:36 PST
,
Vincent Scheib
no flags
Details
Formatted Diff
Diff
Patch
(14.14 KB, patch)
2013-02-20 13:55 PST
,
Vincent Scheib
no flags
Details
Formatted Diff
Diff
Patch
(14.14 KB, patch)
2013-02-20 14:11 PST
,
Vincent Scheib
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Vincent Scheib
Comment 1
2013-02-20 13:36:57 PST
Created
attachment 189365
[details]
Patch
Adam Barth
Comment 2
2013-02-20 13:46:16 PST
Comment on
attachment 189365
[details]
Patch Should we use FeatureObserver to see how often sites use the prefixed versus the unprefixed attribute? (We can do that in a followup patch if you like.)
Vincent Scheib
Comment 3
2013-02-20 13:55:15 PST
Created
attachment 189369
[details]
Patch
WebKit Review Bot
Comment 4
2013-02-20 14:07:16 PST
Attachment 189369
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fullscreen/full-screen-enabled-prefixed-expected.txt', u'LayoutTests/fullscreen/full-screen-enabled-prefixed.html', u'LayoutTests/fullscreen/full-screen-enabled.html', u'LayoutTests/fullscreen/full-screen-iframe-allowed-prefixed-expected.txt', u'LayoutTests/fullscreen/full-screen-iframe-allowed-prefixed.html', u'LayoutTests/fullscreen/full-screen-iframe-allowed.html', u'LayoutTests/fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute-expected.txt', u'LayoutTests/fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute.html', u'LayoutTests/fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe1.html', u'LayoutTests/fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe2.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/html/HTMLAttributeNames.in']" exit_code: 1 LayoutTests/ChangeLog:21: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Vincent Scheib
Comment 5
2013-02-20 14:11:17 PST
Created
attachment 189373
[details]
Patch
Vincent Scheib
Comment 6
2013-02-20 14:12:17 PST
Thanks. FeatureObserver requires some thought about when and how to measure it -- e.g. per fullscreenRequest, for each nested iframe, for each iframe parsed, etc. I think it should be thought out and done in a separate patch if we want that data. Also, please re-flag review bit -- I accidentally dropped it on the follow-up patch upload (had omitted one of the new test expectations).
Vincent Scheib
Comment 7
2013-02-20 16:34:09 PST
Committed
r143533
: <
http://trac.webkit.org/changeset/143533
>
Jer Noble
Comment 8
2013-02-20 16:55:39 PST
***
Bug 110400
has been marked as a duplicate of this bug. ***
Jer Noble
Comment 9
2013-02-20 16:56:52 PST
Great minds. ;)
Vincent Scheib
Comment 10
2013-02-20 17:22:14 PST
Ha! ;)
Eric Seidel (no email)
Comment 11
2013-03-01 02:54:54 PST
Comment on
attachment 189373
[details]
Patch Cleared review? from
attachment 189373
[details]
so that this bug does not appear in
http://webkit.org/pending-review
. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug