RESOLVED FIXED110371
Cleanup dead MediaSource code after Chromium refactor completes 
https://bugs.webkit.org/show_bug.cgi?id=110371
Summary Cleanup dead MediaSource code after Chromium refactor completes
Aaron Colwell
Reported 2013-02-20 13:16:00 PST
This is a follow up bug for cleaning up dead WebKit code, once the MediaSource refactor (https://bugs.webkit.org/show_bug.cgi?id=109857) lands and the Chromium WebMediaPlayerImpl implements its own version of WebMediaPlayer::load(WebURL, WebMediaSource, CORSMode). Once this happens the following code can be removed. - WebMediaSourceClientImpl in WebMediaPlayerClientImpl.cpp - WebMediaPlayerClientImpl::sourceOpened() - WebMediaPlayerClientImpl::sourceURL() - The default implementation of WebMediaPlayer::load(WebURL, WebMediaSource, CORSMode)
Attachments
Patch (11.18 KB, patch)
2013-03-08 09:51 PST, Aaron Colwell 		no flags
DetailsFormatted DiffDiff
Rebase (11.25 KB, patch)
2013-03-12 19:12 PDT, Aaron Colwell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aaron Colwell
Comment 1 2013-03-08 09:51:59 PST
Created attachment 192242 [details] Patch
WebKit Review Bot
Comment 2 2013-03-08 09:54:47 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 3 2013-03-08 09:55:41 PST
Comment on attachment 192242 [details] Patch Attachment 192242 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17016243
WebKit Review Bot
Comment 4 2013-03-08 09:56:30 PST
Comment on attachment 192242 [details] Patch Attachment 192242 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17027281
Peter Beverloo (cr-android ews)
Comment 5 2013-03-08 10:01:33 PST
Comment on attachment 192242 [details] Patch Attachment 192242 [details] did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/17068503
Aaron Colwell
Comment 6 2013-03-12 19:12:56 PDT
Created attachment 192856 [details] Rebase
WebKit Review Bot
Comment 7 2013-03-13 08:40:11 PDT
Comment on attachment 192856 [details] Rebase Clearing flags on attachment: 192856 Committed r145721: <http://trac.webkit.org/changeset/145721>
WebKit Review Bot
Comment 8 2013-03-13 08:40:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.