Bug 110348 - Web Inspector: CSSProperty.status defaults to "style" not "active"
Summary: Web Inspector: CSSProperty.status defaults to "style" not "active"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-20 07:30 PST by Timothy Hatcher
Modified: 2013-02-20 08:10 PST (History)
11 users (show)

See Also:


Attachments
Patch (2.82 KB, patch)
2013-02-20 07:34 PST, Alexander Pavlov (apavlov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-02-20 07:30:00 PST
The code and the json file description disagree on what an absent "status" means.

Inspector.json:
                    { "name": "status", "type": "string", "enum": ["active", "inactive", "disabled", "style"], "optional": true, "description": "The property status: \"active\" (implied if absent) if the property is effective in the style, \"inactive\" if the property is overridden by a same-named property in this style later on, \"disabled\" if the property is disabled by the user, \"style\" if the property is reported by the browser rather than by the CSS source parser." },

InspectorStyleSheet.cpp:
        // Default "status" == "style".
        if (status != TypeBuilder::CSS::CSSProperty::Status::Style)
            property->setStatus(status);

Defaulting to "style" makes more sense to me, and the code agrees.
Comment 1 Alexander Pavlov (apavlov) 2013-02-20 07:34:21 PST
Created attachment 189316 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-20 08:10:05 PST
Comment on attachment 189316 [details]
Patch

Clearing flags on attachment: 189316

Committed r143465: <http://trac.webkit.org/changeset/143465>
Comment 3 WebKit Review Bot 2013-02-20 08:10:09 PST
All reviewed patches have been landed.  Closing bug.