RESOLVED FIXED 110348
Web Inspector: CSSProperty.status defaults to "style" not "active" 
https://bugs.webkit.org/show_bug.cgi?id=110348
Summary Web Inspector: CSSProperty.status defaults to "style" not "active"
Timothy Hatcher
Reported 2013-02-20 07:30:00 PST
The code and the json file description disagree on what an absent "status" means. Inspector.json: { "name": "status", "type": "string", "enum": ["active", "inactive", "disabled", "style"], "optional": true, "description": "The property status: \"active\" (implied if absent) if the property is effective in the style, \"inactive\" if the property is overridden by a same-named property in this style later on, \"disabled\" if the property is disabled by the user, \"style\" if the property is reported by the browser rather than by the CSS source parser." }, InspectorStyleSheet.cpp: // Default "status" == "style". if (status != TypeBuilder::CSS::CSSProperty::Status::Style) property->setStatus(status); Defaulting to "style" makes more sense to me, and the code agrees.
Attachments
Patch (2.82 KB, patch)
2013-02-20 07:34 PST, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2013-02-20 07:34:21 PST
Created attachment 189316 [details] Patch
WebKit Review Bot
Comment 2 2013-02-20 08:10:05 PST
Comment on attachment 189316 [details] Patch Clearing flags on attachment: 189316 Committed r143465: <http://trac.webkit.org/changeset/143465>
WebKit Review Bot
Comment 3 2013-02-20 08:10:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.