RESOLVED FIXED 110317
Add an ASSERT to didChangeDeviceProximity 
https://bugs.webkit.org/show_bug.cgi?id=110317
Summary Add an ASSERT to didChangeDeviceProximity
Kihong Kwon
Reported 2013-02-20 02:31:46 PST
Proximity event is occurred normally even if value is less than min or more then max. Therefore we need to add checking the range of proximity value.
Attachments
Patch (4.53 KB, patch)
2013-02-20 02:43 PST, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Patch (4.79 KB, patch)
2013-02-22 21:31 PST, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kihong Kwon
Comment 1 2013-02-20 02:43:18 PST
Created attachment 189271 [details] Patch
Hajime Morrita
Comment 2 2013-02-21 21:05:44 PST
Comment on attachment 189271 [details] Patch I wonder whether this should be done in WebCore. Why not handle this in client side and just assert the range here?
Kihong Kwon
Comment 3 2013-02-21 21:25:16 PST
(In reply to comment #2) > (From update of attachment 189271 [details]) > I wonder whether this should be done in WebCore. Why not handle this in client side and just assert the range here? As you said, client can check this. IMHO, we need to add a minimal defense in the WebCore, but I'm not strongly sure about this. Could I get your opinion about this?
Hajime Morrita
Comment 4 2013-02-21 22:07:06 PST
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 189271 [details] [details]) > > I wonder whether this should be done in WebCore. Why not handle this in client side and just assert the range here? > > As you said, client can check this. > IMHO, we need to add a minimal defense in the WebCore, but I'm not strongly sure about this. Could I get your opinion about this? Just add an assertion here and a guard on caller side?
Kihong Kwon
Comment 5 2013-02-22 21:21:03 PST
Add ASSERT to didChangeDeviceProximity function to check range of value. In addition, fix some wrong layout test cases.
Kihong Kwon
Comment 6 2013-02-22 21:31:02 PST
Created attachment 189903 [details] Patch
WebKit Review Bot
Comment 7 2013-02-24 18:04:02 PST
Comment on attachment 189903 [details] Patch Clearing flags on attachment: 189903 Committed r143882: <http://trac.webkit.org/changeset/143882>
WebKit Review Bot
Comment 8 2013-02-24 18:04:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.