Bug 110315 - Web Inspector: fix message for non-existent domain warning
Summary: Web Inspector: fix message for non-existent domain warning
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-20 01:54 PST by Yury Semikhatsky
Modified: 2013-02-20 04:17 PST (History)
9 users (show)

See Also:


Attachments
Patch (8.76 KB, patch)
2013-02-20 01:57 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch (8.76 KB, patch)
2013-02-20 03:52 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2013-02-20 01:54:58 PST
1. Open inspector for some page and make sure that profiles panel hasn't been shown
2. Navigate inspected page to another URL
3. Open inspector on inspector and look at the console

Result:
Two errors that there were messages for non-existent profiler domains.
Comment 1 Yury Semikhatsky 2013-02-20 01:57:18 PST
Created attachment 189266 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2013-02-20 01:59:21 PST
Comment on attachment 189266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189266&action=review

> Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp:102
>      // Revisit this.

Is this comment still necessary?
Comment 3 Yury Semikhatsky 2013-02-20 03:52:31 PST
Created attachment 189281 [details]
Patch
Comment 4 Yury Semikhatsky 2013-02-20 03:52:56 PST
(In reply to comment #2)
> (From update of attachment 189266 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=189266&action=review
> 
> > Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp:102
> >      // Revisit this.
> 
> Is this comment still necessary?

No. Removed.
Comment 5 WebKit Review Bot 2013-02-20 04:17:34 PST
Comment on attachment 189281 [details]
Patch

Clearing flags on attachment: 189281

Committed r143449: <http://trac.webkit.org/changeset/143449>
Comment 6 WebKit Review Bot 2013-02-20 04:17:38 PST
All reviewed patches have been landed.  Closing bug.