EFL port has used EINA_LOG_XXX to display error message. However, some EFL files use fprintf instead of EINA_LOG macro. FYI, we can see EINA_LOG message as below method, 1. export EINA_LOG_LEVEL=level value(e.g. Set 3) EINA_LOG_LEVEL_CRITICAL = 0 EINA_LOG_LEVEL_ERR = 1 EINA_LOG_LEVEL_WARN = 2 EINA_LOG_LEVEL_INFO = 3 EINA_LOG_LEVEL_DBG = 4 2. Run MiniBrowser.
Created attachment 189261 [details] Patch
Created attachment 189432 [details] Patch
What do you think about using the WebKit logging macros (e.g. LOG_ERROR) consistently instead - the same way it as it is in some parts of WebContextEfl.cpp ?
(In reply to comment #3) > What do you think about using the WebKit logging macros (e.g. LOG_ERROR) consistently instead - the same way it as it is in some parts of WebContextEfl.cpp ? Yes, EFL port can use LOG() macro. So, I don't mind to use LOG_ERROR(). If there is not objection to use LOG(), I'd like to change all EINA_LOG with LOG() macro. What do you think ?
(In reply to comment #4) > (In reply to comment #3) > > What do you think about using the WebKit logging macros (e.g. LOG_ERROR) consistently instead - the same way it as it is in some parts of WebContextEfl.cpp ? > > Yes, EFL port can use LOG() macro. So, I don't mind to use LOG_ERROR(). If there is not objection to use LOG(), I'd like to change all EINA_LOG with LOG() macro. What do you think ? I think in places where it is proper to include wtf we should prefer the WebKit LOG macros as it generate a consistent/combined log and helps later move the code around.
Laszlo, as we talked on Bug 110452, LOG_DEBUG(or, similar things) may make unneeded logs when developer wanna see needed log. So, it looks there is no good alternative solution. So, I'd like to use EINA_LOG as is. Please take a look this patch again. (I don't wanna remove current log in this bug. It needs to investigate further.)
Comment on attachment 189432 [details] Patch r=me. Thanks for checking the alternatives.
Comment on attachment 189432 [details] Patch Clearing flags on attachment: 189432 Committed r143832: <http://trac.webkit.org/changeset/143832>
All reviewed patches have been landed. Closing bug.