Bug 110296 - [New Multicolumn] Make layers paint properly in columns
Summary: [New Multicolumn] Make layers paint properly in columns
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
Depends on:
Reported: 2013-02-19 21:07 PST by Dave Hyatt
Modified: 2013-02-20 09:01 PST (History)
6 users (show)

See Also:

Patch (15.69 KB, patch)
2013-02-19 21:13 PST, Dave Hyatt
sam: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (16.41 KB, patch)
2013-02-20 08:32 PST, Dave Hyatt
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2013-02-19 21:07:00 PST
Make layers paint properly in columns in both LTR and RTL cases.
Comment 1 Dave Hyatt 2013-02-19 21:13:00 PST
Created attachment 189230 [details]
Comment 2 WebKit Review Bot 2013-02-19 21:16:09 PST
Attachment 189230 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/multicol/newmulticol/layers-in-multicol-expected.html', u'LayoutTests/fast/multicol/newmulticol/layers-in-multicol.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnSet.cpp', u'Source/WebCore/rendering/RenderRegion.cpp']" exit_code: 1
Source/WebCore/rendering/RenderRegion.cpp:45:  Use 'using namespace std;' instead of 'using std::min;'.  [build/using_std] [4]
Source/WebCore/rendering/RenderRegion.cpp:46:  Use 'using namespace std;' instead of 'using std::max;'.  [build/using_std] [4]
Total errors found: 2 in 7 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2013-02-19 21:51:45 PST
Comment on attachment 189230 [details]

Attachment 189230 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16650067

New failing tests:
Comment 4 Dave Hyatt 2013-02-20 08:32:15 PST
Created attachment 189325 [details]

Fix style issue and skip the failing test on chromium.
Comment 5 Dave Hyatt 2013-02-20 09:01:42 PST
Fixed in r143467.