RESOLVED FIXED 110284
EME: Enable both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 until clients transition to the new API. 
https://bugs.webkit.org/show_bug.cgi?id=110284
Summary EME: Enable both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 until clients transit...
Jer Noble
Reported 2013-02-19 17:14:51 PST
EME: Enable both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 until clients transition to the new API.
Attachments
Patch (6.99 KB, patch)
2013-02-20 11:07 PST, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2013-02-20 11:07:26 PST
Created attachment 189341 [details] Patch
Laszlo Gombos
Comment 2 2013-02-20 13:11:44 PST
I would recommend changing FeatureDefines.h instead (only one change): Index: FeatureDefines.h =================================================================== --- FeatureDefines.h (revision 143483) +++ FeatureDefines.h (working copy) @@ -132,6 +132,12 @@ #endif #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 +#if !defined(ENABLE_ENCRYPTED_MEDIA) +#define ENABLE_ENCRYPTED_MEDIA 1 +#endif +#endif + +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 #if !defined(ENABLE_ENCRYPTED_MEDIA_V2) #define ENABLE_ENCRYPTED_MEDIA_V2 1 #endif If you change FeatureDefines.xcconfig, you need to change all 4 of them together as it is described in the file: // The contents of this file must be kept in sync with FeatureDefines.xcconfig in JavaScriptCore, // WebCore, WebKit and WebKit2. Also the default values of the ENABLE_FEATURE_NAME macros in // build-webkit should match the values below, but they do not need to be in the same order.
Jer Noble
Comment 3 2013-02-20 14:51:25 PST
Committed r143509: <http://trac.webkit.org/changeset/143509>
Laszlo Gombos
Comment 4 2013-02-25 20:51:40 PST
(In reply to comment #2) > I would recommend changing FeatureDefines.h instead .......etc.. Fixed in r143984 .
Note You need to log in before you can comment on or make changes to this bug.