RESOLVED FIXED 110273
webdatabase: Introduce AbstractSQLTransaction and AbstractSQLTransactionBackend 
https://bugs.webkit.org/show_bug.cgi?id=110273
Summary webdatabase: Introduce AbstractSQLTransaction and AbstractSQLTransactionBackend
Mark Lam
Reported 2013-02-19 15:56:20 PST
Need to define the transaction interface between the front end and backend.
Attachments
the patch. (16.81 KB, patch)
2013-02-19 16:01 PST, Mark Lam 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2013-02-19 16:01:10 PST
Created attachment 189191 [details] the patch.
Anders Carlsson
Comment 2 2013-02-19 16:06:32 PST
Comment on attachment 189191 [details] the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=189191&action=review > Source/WebCore/Modules/webdatabase/SQLTransaction.h:79 > + virtual void requestTransitToState(SQLTransactionState); > + virtual bool hasCallback() const; > + virtual bool hasSuccessCallback() const; > + virtual bool hasErrorCallback() const; > + virtual void setBackend(AbstractSQLTransactionBackend*); You should add OVERRIDE to these. > Source/WebCore/Modules/webdatabase/SQLTransactionBackend.h:84 > + virtual void requestTransitToState(SQLTransactionState); > + virtual PassRefPtr<SQLError> transactionError(); > + virtual AbstractSQLStatement* currentStatement(); > + virtual void setShouldRetryCurrentStatement(bool); > + virtual void executeSQL(PassOwnPtr<AbstractSQLStatement>, const String& statement, > + const Vector<SQLValue>& arguments, int permissions); And here.
Mark Lam
Comment 3 2013-02-19 16:51:38 PST
Thanks for there review. Adjusted patch based on feedback. Landed in r143412: <http://trac.webkit.org/changeset/143412>.
Note You need to log in before you can comment on or make changes to this bug.