Bug 110268 - StorageAreaProxy should know its quota
Summary: StorageAreaProxy should know its quota
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-19 15:08 PST by Anders Carlsson
Modified: 2013-02-19 15:33 PST (History)
0 users

See Also:


Attachments
Patch (5.60 KB, patch)
2013-02-19 15:13 PST, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-02-19 15:08:45 PST
StorageAreaProxy should know its quota
Comment 1 Anders Carlsson 2013-02-19 15:13:19 PST
Created attachment 189178 [details]
Patch
Comment 2 Sam Weinig 2013-02-19 15:17:07 PST
Comment on attachment 189178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189178&action=review

> Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp:97
> +    exceptionCode = 0;

I think we usually call this ec.

> Source/WebKit2/WebProcess/Storage/StorageNamespaceProxy.h:58
> +    unsigned m_quota;

What units is this in terms of.  Please either add a comment or make the name more descriptive.
Comment 3 Anders Carlsson 2013-02-19 15:33:35 PST
Committed r143396: <http://trac.webkit.org/changeset/143396>