RESOLVED FIXED110256
[BlackBerry] Move posting and scrollbar updates to the page client 
https://bugs.webkit.org/show_bug.cgi?id=110256
Summary [BlackBerry] Move posting and scrollbar updates to the page client
Jakob Petsovits
Reported 2013-02-19 13:27:16 PST
In blitVisibleContents(), we were calling the WebKit thread functions BackingStorePrivate::isScrollingOrZooming() and WebPage::isVisible(). This is not the right spot to do it. Furthermore, we want to move away from direct window access in WebKit and leave that kind of dirtywork to the client. The patch below removes invalidateWindow() as well as the two virtual scrollbar drawing functions and replaces it with one new virtual, WebPageClient::postToSurface(). This clears up threading issues and gets us another step further towards pure WebPageCompositor rendering.
Attachments
Patch (6.34 KB, patch)
2013-02-19 13:33 PST, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jakob Petsovits
Comment 1 2013-02-19 13:33:12 PST
Created attachment 189153 [details] Patch
Arvid Nilsson
Comment 2 2013-02-19 22:31:59 PST
Comment on attachment 189153 [details] Patch I feel the "Post" terminology is a QNXism, it should be possible to find a term that makes more sense from a WebKit perspective. The method will eventually call eglSwapBuffers (or a subrect swapping extension). But I guess "Swap" would be an EGLism. So LGTM.
Jakob Petsovits
Comment 3 2013-02-19 23:01:56 PST
I guess "Post" is strong in QNX land, but not exclusive to it. The EGL_NV_post_sub_buffer extension for instance adopted the same nomenclature for the same functionality after also considering "Present" or "Copy" as alternatives. In my understanding, "Swap" refers more to the concept of replacing the full buffer rather than presenting a portion of the buffer in the target window or parent container. I guess a "Post" will usually flush commands and swap surfaces like eglSwapBuffers() would, but at least the swapping part seems like it could be optional in some implementations and the focus is on propagating the contents to the screen or parent container, which is more the intention of this patch. Thanks for your input!
Rob Buis
Comment 4 2013-02-21 08:05:03 PST
Comment on attachment 189153 [details] Patch Ok.
WebKit Review Bot
Comment 5 2013-02-21 08:51:48 PST
Comment on attachment 189153 [details] Patch Clearing flags on attachment: 189153 Committed r143610: <http://trac.webkit.org/changeset/143610>
WebKit Review Bot
Comment 6 2013-02-21 08:51:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.