Bug 110254 - [V8] ScriptRunner::runCompiledScript() should return Handle<Value>() when OOM occurs
Summary: [V8] ScriptRunner::runCompiledScript() should return Handle<Value>() when OOM...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Reported: 2013-02-19 12:42 PST by Kentaro Hara
Modified: 2013-02-19 15:03 PST (History)
3 users (show)

See Also:

Patch (1.74 KB, patch)
2013-02-19 12:44 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-02-19 12:42:15 PST
Chromium bug: https://code.google.com/p/chromium/issues/detail?id=176951

Currently ScriptRunner::runCompiledScript() calls ASSERT(script.IsEmpty()) when OOM occurs. The Chromium bug is hitting the ASSERT(). The ASSERT() does not make sense at all. Instead, we should return an empty handle when OOM occurs.
Comment 1 Kentaro Hara 2013-02-19 12:44:08 PST
Created attachment 189145 [details]
Comment 2 WebKit Review Bot 2013-02-19 15:03:02 PST
Comment on attachment 189145 [details]

Clearing flags on attachment: 189145

Committed r143387: <http://trac.webkit.org/changeset/143387>
Comment 3 WebKit Review Bot 2013-02-19 15:03:06 PST
All reviewed patches have been landed.  Closing bug.