Bug 110253 - [BlackBerry] Appropriately handle word wrapping in SpellingHandler
Summary: [BlackBerry] Appropriately handle word wrapping in SpellingHandler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nima Ghanavatian
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-19 12:37 PST by Nima Ghanavatian
Modified: 2013-02-19 15:17 PST (History)
5 users (show)

See Also:

Attachments
Patch (21.94 KB, patch)
2013-02-19 12:56 PST, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
Patch (21.85 KB, patch)
2013-02-19 13:16 PST, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
Patch (21.84 KB, patch)
2013-02-19 13:27 PST, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nima Ghanavatian 2013-02-19 12:37:42 PST 
ssia
Comment 1 Nima Ghanavatian 2013-02-19 12:56:55 PST 
Created attachment 189147 [details]
Patch
Comment 2 Rob Buis 2013-02-19 13:08:45 PST 
Comment on attachment 189147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189147&action=review

Found some small nits.

> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:535
> +            endPosition = textRender->visiblePositionForIndex(textLength);

I'd reverse the logic here.

> Source/WebKit/blackberry/WebKitSupport/SpellingHandler.h:35
> +    void setSpellCheckActive(const bool active) { m_isSpellCheckActive = active; }

I am not sure const bool adds anything? It will not make it more efficient AFAICS.
Comment 3 Nima Ghanavatian 2013-02-19 13:16:40 PST 
Created attachment 189150 [details]
Patch
Comment 4 Nima Ghanavatian 2013-02-19 13:27:03 PST 
Created attachment 189152 [details]
Patch
Comment 5 Rob Buis 2013-02-19 13:30:27 PST 
Comment on attachment 189152 [details]
Patch

Looks good.
Comment 6 WebKit Review Bot 2013-02-19 15:17:24 PST 
Comment on attachment 189152 [details]
Patch

Clearing flags on attachment: 189152

Committed r143391: <http://trac.webkit.org/changeset/143391>
Comment 7 WebKit Review Bot 2013-02-19 15:17:27 PST 
All reviewed patches have been landed.  Closing bug.