Bug 110245 – [GTK] Add Clutter to jhbuild

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Joone Hur]

This is necessary for enabling Accelerated Compositig with Clutter.

[Joone Hur]

Created attachment 189158 [details]
jhbuild-clutter.modules

This is a jhbuild module file for enabling AC with Clutter.
You can save this file in WebKit/Tools/gtk and build WebKitGtk+ with Clutter easily as follows:

$ export WEBKIT_EXTRA_MODULESETS=file:///home/joone/git/WebKit/Tools/gtk/jhbuild-clutter.modules,file:///home/joone/git/WebKit/Tools/gtk/jhbuild-optional.modules
$ export WEBKIT_EXTRA_MODULES=webkitgtk-clutter-dependencies
$ ./Tools/Scripts/build-webkit --gtk --with-acceleration-backend=clutter --no-webgl

I think that this module file can be added to WebKitGtk+.

[Martin Robinson]

Perhaps it could be added to jhbuild-optional.modules?

[ChangSeok Oh]

(In reply to comment #2)
> Perhaps it could be added to jhbuild-optional.modules?

Why not? I hope joone you'll do it so. :)

[Joone Hur]

Created attachment 189819 [details]
Patch

[Martin Robinson]

Comment on attachment 189819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189819&action=review

> Tools/gtk/jhbuild-optional.modules:24
> +  <metamodule id="webkitgtk-clutter-dependencies">
> +    <dependencies>
> +      <dep package="atk"/>
> +      <dep package="cairo"/>
> +      <dep package="clutter"/>
> +      <dep package="clutter-gtk"/>
> +      <dep package="cogl"/>
> +      <dep package="freetype6"/>
> +      <dep package="gdk-pixbuf"/>
> +      <dep package="gtk+"/>
> +      <dep package="glib"/>
> +      <dep package="json-glib"/>
> +    </dependencies>
> +  </metamodule>
> +

Many of these modules are already in the main jhbuild. Why are they repeated here?

[Joone Hur]

> Many of these modules are already in the main jhbuild. Why are they repeated here?

I thought that all dependencies had to be included in jhbuild-optional.modules, but they don't need to be included. I will update the patch soon.

[Joone Hur]

Created attachment 189872 [details]
Patch

[Martin Robinson]

Comment on attachment 189872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189872&action=review

> Tools/gtk/jhbuild-optional.modules:74
> +  <autotools id="atk"
> +           autogen-sh="configure"
> +           autogenargs="--disable-introspection">
> +    <branch module="/pub/GNOME/sources/atk/2.5/atk-2.5.3.tar.xz" version="2.5.3"
> +            repo="ftp.gnome.org"
> +            hash="sha256:ac118ef34ef5490fa113cf50cffdff7735d6293723bf35df958a89fbda876313"/>

Is there some reason you need to include ATK here? Most distributions come with -dev versions of ATK? I wonder the same thing about json-glib. It'd be good to only include dependencies that are difficult to get in most distributions.

[Joone Hur]

(In reply to comment #8)
> (From update of attachment 189872 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=189872&action=review
> 
> > Tools/gtk/jhbuild-optional.modules:74
> > +  <autotools id="atk"
> > +           autogen-sh="configure"
> > +           autogenargs="--disable-introspection">
> > +    <branch module="/pub/GNOME/sources/atk/2.5/atk-2.5.3.tar.xz" version="2.5.3"
> > +            repo="ftp.gnome.org"
> > +            hash="sha256:ac118ef34ef5490fa113cf50cffdff7735d6293723bf35df958a89fbda876313"/>
> 
> Is there some reason you need to include ATK here? Most distributions come with -dev versions of ATK? I wonder the same thing about json-glib. It'd be good to only include dependencies that are difficult to get in most distributions.

I'm using Ubuntu 12.04 that has atk 2.4.0, but we need 2.5.3 or higher. Ubuntu 12.10 has 2.6.0 so this is the similar case of libsecret.

In the case of json-glib, we don't need include it on Ubuntu 12.04 or higher, so I will remove it.

[Joone Hur]

Created attachment 190135 [details]
Patch

[ChangSeok Oh]

Great patch to me! Thanks :)

[WebKit Review Bot]

Comment on attachment 190135 [details]
Patch

Clearing flags on attachment: 190135

Committed r144028: <http://trac.webkit.org/changeset/144028>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.