Bug 110245 - [GTK] Add Clutter to jhbuild
Summary: [GTK] Add Clutter to jhbuild
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joone Hur
URL:
Keywords:
Depends on:
Blocks: 105699
  Show dependency treegraph
 
Reported: 2013-02-19 11:43 PST by Joone Hur
Modified: 2013-02-26 02:07 PST (History)
4 users (show)

See Also:


Attachments
jhbuild-clutter.modules (6.13 KB, application/octet-stream)
2013-02-19 13:54 PST, Joone Hur
no flags Details
Patch (7.38 KB, patch)
2013-02-22 13:59 PST, Joone Hur
no flags Details | Formatted Diff | Diff
Patch (3.97 KB, patch)
2013-02-22 17:26 PST, Joone Hur
no flags Details | Formatted Diff | Diff
Patch (3.54 KB, patch)
2013-02-25 15:13 PST, Joone Hur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joone Hur 2013-02-19 11:43:29 PST
This is necessary for enabling Accelerated Compositig with Clutter.
Comment 1 Joone Hur 2013-02-19 13:54:26 PST
Created attachment 189158 [details]
jhbuild-clutter.modules

This is a jhbuild module file for enabling AC with Clutter.
You can save this file in WebKit/Tools/gtk and build WebKitGtk+ with Clutter easily as follows:

$ export WEBKIT_EXTRA_MODULESETS=file:///home/joone/git/WebKit/Tools/gtk/jhbuild-clutter.modules,file:///home/joone/git/WebKit/Tools/gtk/jhbuild-optional.modules
$ export WEBKIT_EXTRA_MODULES=webkitgtk-clutter-dependencies
$ ./Tools/Scripts/build-webkit --gtk --with-acceleration-backend=clutter --no-webgl

I think that this module file can be added to WebKitGtk+.
Comment 2 Martin Robinson 2013-02-19 13:56:24 PST
Perhaps it could be added to jhbuild-optional.modules?
Comment 3 ChangSeok Oh 2013-02-19 14:22:38 PST
(In reply to comment #2)
> Perhaps it could be added to jhbuild-optional.modules?

Why not? I hope joone you'll do it so. :)
Comment 4 Joone Hur 2013-02-22 13:59:58 PST
Created attachment 189819 [details]
Patch
Comment 5 Martin Robinson 2013-02-22 14:17:37 PST
Comment on attachment 189819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189819&action=review

> Tools/gtk/jhbuild-optional.modules:24
> +  <metamodule id="webkitgtk-clutter-dependencies">
> +    <dependencies>
> +      <dep package="atk"/>
> +      <dep package="cairo"/>
> +      <dep package="clutter"/>
> +      <dep package="clutter-gtk"/>
> +      <dep package="cogl"/>
> +      <dep package="freetype6"/>
> +      <dep package="gdk-pixbuf"/>
> +      <dep package="gtk+"/>
> +      <dep package="glib"/>
> +      <dep package="json-glib"/>
> +    </dependencies>
> +  </metamodule>
> +

Many of these modules are already in the main jhbuild. Why are they repeated here?
Comment 6 Joone Hur 2013-02-22 17:24:16 PST
> Many of these modules are already in the main jhbuild. Why are they repeated here?

I thought that all dependencies had to be included in jhbuild-optional.modules, but they don't need to be included. I will update the patch soon.
Comment 7 Joone Hur 2013-02-22 17:26:34 PST
Created attachment 189872 [details]
Patch
Comment 8 Martin Robinson 2013-02-22 17:39:59 PST
Comment on attachment 189872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189872&action=review

> Tools/gtk/jhbuild-optional.modules:74
> +  <autotools id="atk"
> +           autogen-sh="configure"
> +           autogenargs="--disable-introspection">
> +    <branch module="/pub/GNOME/sources/atk/2.5/atk-2.5.3.tar.xz" version="2.5.3"
> +            repo="ftp.gnome.org"
> +            hash="sha256:ac118ef34ef5490fa113cf50cffdff7735d6293723bf35df958a89fbda876313"/>

Is there some reason you need to include ATK here? Most distributions come with -dev versions of ATK? I wonder the same thing about json-glib. It'd be good to only include dependencies that are difficult to get in most distributions.
Comment 9 Joone Hur 2013-02-25 15:08:11 PST
(In reply to comment #8)
> (From update of attachment 189872 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=189872&action=review
> 
> > Tools/gtk/jhbuild-optional.modules:74
> > +  <autotools id="atk"
> > +           autogen-sh="configure"
> > +           autogenargs="--disable-introspection">
> > +    <branch module="/pub/GNOME/sources/atk/2.5/atk-2.5.3.tar.xz" version="2.5.3"
> > +            repo="ftp.gnome.org"
> > +            hash="sha256:ac118ef34ef5490fa113cf50cffdff7735d6293723bf35df958a89fbda876313"/>
> 
> Is there some reason you need to include ATK here? Most distributions come with -dev versions of ATK? I wonder the same thing about json-glib. It'd be good to only include dependencies that are difficult to get in most distributions.

I'm using Ubuntu 12.04 that has atk 2.4.0, but we need 2.5.3 or higher. Ubuntu 12.10 has 2.6.0 so this is the similar case of libsecret.

In the case of json-glib, we don't need include it on Ubuntu 12.04 or higher, so I will remove it.
Comment 10 Joone Hur 2013-02-25 15:13:17 PST
Created attachment 190135 [details]
Patch
Comment 11 ChangSeok Oh 2013-02-25 21:40:15 PST
Great patch to me! Thanks :)
Comment 12 WebKit Review Bot 2013-02-26 02:07:39 PST
Comment on attachment 190135 [details]
Patch

Clearing flags on attachment: 190135

Committed r144028: <http://trac.webkit.org/changeset/144028>
Comment 13 WebKit Review Bot 2013-02-26 02:07:43 PST
All reviewed patches have been landed.  Closing bug.