Bug 110239 - [New Multicolumn] REGRESSION: RenderMultiColumnSets broken by the RenderRegion -> RenderBlock subclassing
Summary: [New Multicolumn] REGRESSION: RenderMultiColumnSets broken by the RenderRegio...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
Depends on:
Reported: 2013-02-19 11:09 PST by Dave Hyatt
Modified: 2013-02-19 16:09 PST (History)
6 users (show)

See Also:

Patch (17.98 KB, patch)
2013-02-19 14:35 PST, Dave Hyatt
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2013-02-19 11:09:57 PST
RenderMultiColumnSets were not patched correctly when RenderRegions became RenderBlocks. This bug is covering fixing the paint method to be more like RenderRegion's.
Comment 1 Dave Hyatt 2013-02-19 14:35:21 PST
Created attachment 189165 [details]
Comment 2 Simon Fraser (smfr) 2013-02-19 14:41:45 PST
Comment on attachment 189165 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=189165&action=review

> Source/WebCore/rendering/RenderFlowThread.cpp:254
> +    // layout code that attempts to pixel snap will be incorrect. In general this is a huge problem with
> +    // subpixel layout (that attempts at snapping are just utterly wrong in the presence of any non-integral

Perhaps you could omit this or say it in a more forward-looking way.
Comment 3 Dave Hyatt 2013-02-19 15:25:36 PST
Fixed in r143395.