Bug 110235 - [BlackBerry] Read "data-blackberry-text-selection-handle-position" attribute from element
Summary: [BlackBerry] Read "data-blackberry-text-selection-handle-position" attribute ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-19 10:02 PST by Yongxin Dai
Modified: 2013-02-20 07:26 PST (History)
6 users (show)

See Also:


Attachments
Patch (5.98 KB, patch)
2013-02-19 11:07 PST, Yongxin Dai
no flags Details | Formatted Diff | Diff
Patch (5.98 KB, patch)
2013-02-19 11:38 PST, Yongxin Dai
no flags Details | Formatted Diff | Diff
Patch (5.96 KB, patch)
2013-02-19 11:55 PST, Yongxin Dai
no flags Details | Formatted Diff | Diff
Patch (8.35 KB, patch)
2013-02-20 06:53 PST, Yongxin Dai
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yongxin Dai 2013-02-19 10:02:21 PST
data-blackberry-text-selection-handle-position specifies the position of  selection handles.
Comment 1 Yongxin Dai 2013-02-19 11:07:09 PST
Created attachment 189117 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-19 11:11:22 PST
Attachment 189117 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPageClient.h', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp', u'Source/WebKit/blackberry/WebKitSupport/SelectionHandler.h']" exit_code: 1
Source/WebKit/blackberry/Api/WebPageClient.h:156:  The parameter name "handlePosition" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yongxin Dai 2013-02-19 11:38:56 PST
Created attachment 189124 [details]
Patch
Comment 4 Yongxin Dai 2013-02-19 11:55:35 PST
Created attachment 189129 [details]
Patch
Comment 5 WebKit Review Bot 2013-02-19 13:08:15 PST
Comment on attachment 189129 [details]
Patch

Attachment 189129 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16614998

New failing tests:
platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html
Comment 6 Yongxin Dai 2013-02-20 06:53:04 PST
Created attachment 189311 [details]
Patch
Comment 7 Yong Li 2013-02-20 07:12:07 PST
Comment on attachment 189311 [details]
Patch

based on Mike's review
Comment 8 WebKit Review Bot 2013-02-20 07:26:08 PST
Comment on attachment 189311 [details]
Patch

Clearing flags on attachment: 189311

Committed r143461: <http://trac.webkit.org/changeset/143461>
Comment 9 WebKit Review Bot 2013-02-20 07:26:11 PST
All reviewed patches have been landed.  Closing bug.