Bug 110218 – [WK2] Make WebPageProxy use deviceScaleFactor() in creationParameters().

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Michael Brüning]

[WK2] Make WebPageProxy use deviceScaleFactor() in creationParamaters().

[Michael Brüning]

Created attachment 189081 [details]
Patch

[Michael Brüning]

CCing Beth as she was the last author working on this in WebPageProxy as well as Simon and Kenneth for Qt resp. EFL.

[Andras Becsi]

Comment on attachment 189081 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189081&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:-3732
> -    parameters.deviceScaleFactor = m_intrinsicDeviceScaleFactor;

As Jocelyn pointed out earlier in the first patch to https://bugs.webkit.org/show_bug.cgi?id=97908, the custom device scale factor was designed to only be used temporary.
Maybe we should add C API for setting the intrinsic device scale factor and use that at least for the Qt case, where we get the scale factor from the underlying platform window?

[Michael Brüning]

Created attachment 189086 [details]
Patch

Fixed typo in bug title and ChangeLog text.

[Michael Brüning]

(In reply to comment #3)
> (From update of attachment 189081 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=189081&action=review
> 
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:-3732
> > -    parameters.deviceScaleFactor = m_intrinsicDeviceScaleFactor;
> 
> As Jocelyn pointed out earlier in the first patch to https://bugs.webkit.org/show_bug.cgi?id=97908, the custom device scale factor was designed to only be used temporary.
> Maybe we should add C API for setting the intrinsic device scale factor and use that at least for the Qt case, where we get the scale factor from the underlying platform window?

Hm, while there is no real technical reason to use the custom scale factor for temporary views only, I agree that using it like we do in this patch pretty much renders the intrinsic device scale factor pointless / makes it a de-facto constant in the Efl and Qt ports. I am fine with adding the C API for setting the intrinsic scale too if this is preferable from the API owners' point of view. Let's wait for comments :).

[Andras Becsi]

(In reply to comment #5)
> (In reply to comment #3)
> > (From update of attachment 189081 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=189081&action=review
> > 
> > > Source/WebKit2/UIProcess/WebPageProxy.cpp:-3732
> > > -    parameters.deviceScaleFactor = m_intrinsicDeviceScaleFactor;
> > 
> > As Jocelyn pointed out earlier in the first patch to https://bugs.webkit.org/show_bug.cgi?id=97908, the custom device scale factor was designed to only be used temporary.
> > Maybe we should add C API for setting the intrinsic device scale factor and use that at least for the Qt case, where we get the scale factor from the underlying platform window?
> 
> Hm, while there is no real technical reason to use the custom scale factor for temporary views only, I agree that using it like we do in this patch pretty 
much renders the intrinsic device scale factor pointless / makes it a de-facto constant in the Efl and Qt ports. I am fine with adding the C API for setting the intrinsic scale too if this is preferable from the API owners' point of view. Let's wait for comments :).

I think the point of the custom device pixel ratio would be to temporarily set a device pixel ratio that's different from the intrinsic one for example for testing purposes.
Qt right now does not have a mechanism to set a custom scale factor different from the underlying platform window, thus I think we should set the intrinsic device pixel ratio instead of misusing the custom one.

[Michael Brüning]

Committed r150063: <http://trac.webkit.org/changeset/150063>