Bug 110217 – [chromium] move most of the remaining mocks to TestRunner library

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[chromium] move most of the remaining mocks to TestRunner library

Created attachment 189080 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Comment on attachment 189080 [details]
Patch

Attachment 189080 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16628581

New failing tests:
fast/dom/Geolocation/position-string.html
fast/dom/Geolocation/cached-position-iframe.html
inspector/geolocation-error.html

I guess I'll need to move the mocks to WebTestProxyBase instead of TestRunner.

Anyway, the public/ API changes will stay the same, can I already get a lgtm for that?

[Adam Barth]

Comment on attachment 189080 [details]
Patch

API changes LGTM

Created attachment 189289 [details]
Patch

[WebKit Review Bot]

Attachment 189289 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/DumpRenderTree.gypi', u'Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp', u'Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h', u'Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp', u'Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h', u'Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h', u'Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp', u'Tools/DumpRenderTree/chromium/WebViewHost.cpp', u'Tools/DumpRenderTree/chromium/WebViewHost.h']" exit_code: 1
Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:65:  The parameter name "proxy" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:66:  The parameter name "proxy" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Nico Weber]

Comment on attachment 189289 [details]
Patch

Makes sense. I didn't look super closely since this is just moving existing code around.

Created attachment 189295 [details]
Patch

Created attachment 189297 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 189297 [details]
Patch for landing

Clearing flags on attachment: 189297

Committed r143457: <http://trac.webkit.org/changeset/143457>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.