Bug 110217 - [chromium] move most of the remaining mocks to TestRunner library
Summary: [chromium] move most of the remaining mocks to TestRunner library
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-19 06:49 PST by jochen
Modified: 2013-02-20 06:11 PST (History)
6 users (show)

See Also:


Attachments
Patch (89.90 KB, patch)
2013-02-19 06:50 PST, jochen
no flags Details | Formatted Diff | Diff
Patch (98.00 KB, patch)
2013-02-20 05:22 PST, jochen
no flags Details | Formatted Diff | Diff
Patch (97.99 KB, patch)
2013-02-20 05:36 PST, jochen
no flags Details | Formatted Diff | Diff
Patch for landing (97.98 KB, patch)
2013-02-20 05:37 PST, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2013-02-19 06:49:56 PST
[chromium] move most of the remaining mocks to TestRunner library
Comment 1 jochen 2013-02-19 06:50:52 PST
Created attachment 189080 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-19 06:54:45 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2013-02-19 08:29:56 PST
Comment on attachment 189080 [details]
Patch

Attachment 189080 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16628581

New failing tests:
fast/dom/Geolocation/position-string.html
fast/dom/Geolocation/cached-position-iframe.html
inspector/geolocation-error.html
Comment 4 jochen 2013-02-19 09:06:25 PST
I guess I'll need to move the mocks to WebTestProxyBase instead of TestRunner.

Anyway, the public/ API changes will stay the same, can I already get a lgtm for that?
Comment 5 Adam Barth 2013-02-19 12:12:21 PST
Comment on attachment 189080 [details]
Patch

API changes LGTM
Comment 6 jochen 2013-02-20 05:22:21 PST
Created attachment 189289 [details]
Patch
Comment 7 WebKit Review Bot 2013-02-20 05:34:53 PST
Attachment 189289 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/DumpRenderTree.gypi', u'Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp', u'Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h', u'Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp', u'Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h', u'Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h', u'Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp', u'Tools/DumpRenderTree/chromium/WebViewHost.cpp', u'Tools/DumpRenderTree/chromium/WebViewHost.h']" exit_code: 1
Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:65:  The parameter name "proxy" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:66:  The parameter name "proxy" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Nico Weber 2013-02-20 05:36:24 PST
Comment on attachment 189289 [details]
Patch

Makes sense. I didn't look super closely since this is just moving existing code around.
Comment 9 jochen 2013-02-20 05:36:37 PST
Created attachment 189295 [details]
Patch
Comment 10 jochen 2013-02-20 05:37:24 PST
Created attachment 189297 [details]
Patch for landing
Comment 11 WebKit Review Bot 2013-02-20 06:11:49 PST
Comment on attachment 189297 [details]
Patch for landing

Clearing flags on attachment: 189297

Committed r143457: <http://trac.webkit.org/changeset/143457>
Comment 12 WebKit Review Bot 2013-02-20 06:11:53 PST
All reviewed patches have been landed.  Closing bug.