Bug 110215 - [Qt] Skip the build with a warning if certain tools cannot be found in the PATH
Summary: [Qt] Skip the build with a warning if certain tools cannot be found in the PATH
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Hausmann
Depends on:
Reported: 2013-02-19 06:18 PST by Simon Hausmann
Modified: 2013-02-19 06:45 PST (History)
3 users (show)

See Also:

Patch (3.47 KB, patch)
2013-02-19 06:20 PST, Simon Hausmann
vestbo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2013-02-19 06:18:58 PST
[Qt] Skip the build with a warning if certain tools cannot be found in the PATH
Comment 1 Simon Hausmann 2013-02-19 06:20:57 PST
Created attachment 189073 [details]
Comment 2 Oswald Buddenhagen 2013-02-19 06:36:28 PST
Comment on attachment 189073 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=189073&action=review

> Tools/qmake/mkspecs/features/configure.prf:120
> +    for(program, requiredPrograms):!programExistsInPath($$program) {

weird style. either put it all on one line, or nest properly. consider line continuations:

  for(): \
     !exists(): \

> Tools/qmake/mkspecs/features/configure.prf:240
> +            log("$${EOL}The WebKit build is unfortunately disabled for the following reasons: " $$skipBuildReason "$${EOL}$${EOL}")

"was disabled". omit the "unfortunately", it feels ridiculous to read something like that.

it's not necessary to "interrupt" the quoting.

> Tools/qmake/mkspecs/features/functions.prf:207
> +    unset(program)

remove this line

> Tools/qmake/mkspecs/features/functions.prf:211
> +    PATH="$$(PATH)"

should add spaces around the equal signs. everywhere.

> Tools/qmake/mkspecs/features/functions.prf:215
> +    exists($$GNUTOOLS_DIR): paths = $$paths $$GNUTOOLS_DIR

paths +=

> Tools/qmake/mkspecs/features/functions.prf:217
> +    for(p, paths): exists($$p$$QMAKE_DIR_SEP$$program):return(true)

just use slash for the separator

> Tools/qmake/mkspecs/features/functions.prf:222
> +    skipBuildReason = $$skipBuildReason$${EOL}"    * "$$1

i think it would be cleaner to put the entire string into quotes instead
Comment 3 Simon Hausmann 2013-02-19 06:45:27 PST
Landed with Ossi's proposed changes

Committed r143326: <http://trac.webkit.org/changeset/143326>