[Qt] Skip the build with a warning if certain tools cannot be found in the PATH
Created attachment 189073 [details] Patch
Comment on attachment 189073 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189073&action=review > Tools/qmake/mkspecs/features/configure.prf:120 > + for(program, requiredPrograms):!programExistsInPath($$program) { weird style. either put it all on one line, or nest properly. consider line continuations: for(): \ !exists(): \ addReason() > Tools/qmake/mkspecs/features/configure.prf:240 > + log("$${EOL}The WebKit build is unfortunately disabled for the following reasons: " $$skipBuildReason "$${EOL}$${EOL}") "was disabled". omit the "unfortunately", it feels ridiculous to read something like that. it's not necessary to "interrupt" the quoting. > Tools/qmake/mkspecs/features/functions.prf:207 > + unset(program) remove this line > Tools/qmake/mkspecs/features/functions.prf:211 > + PATH="$$(PATH)" should add spaces around the equal signs. everywhere. > Tools/qmake/mkspecs/features/functions.prf:215 > + exists($$GNUTOOLS_DIR): paths = $$paths $$GNUTOOLS_DIR paths += > Tools/qmake/mkspecs/features/functions.prf:217 > + for(p, paths): exists($$p$$QMAKE_DIR_SEP$$program):return(true) just use slash for the separator > Tools/qmake/mkspecs/features/functions.prf:222 > + skipBuildReason = $$skipBuildReason$${EOL}" * "$$1 i think it would be cleaner to put the entire string into quotes instead
Landed with Ossi's proposed changes Committed r143326: <http://trac.webkit.org/changeset/143326>