Bug 110192 - WebAudio API: Change the Platform::createAudioDevice function to take a DeviceId parameter
Summary: WebAudio API: Change the Platform::createAudioDevice function to take a Devic...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 109494
  Show dependency tree / graph
 
Reported: 2013-02-19 01:32 PST by Tommy Widenflycht
Modified: 2013-03-01 13:31 PST (History)
8 users (show)

See Also:

Attachments
Patch (2.13 KB, patch)
2013-02-19 01:33 PST, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2013-02-19 01:32:59 PST 
WebAudio API: Change the Platform::createAudioDevice function to take a DeviceId parameter
Comment 1 Tommy Widenflycht 2013-02-19 01:33:39 PST 
Created attachment 189022 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-19 01:36:57 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2013-02-19 11:06:05 PST 
Comment on attachment 189022 [details]
Patch

ok
Comment 4 Chris Rogers 2013-02-19 12:10:23 PST 
Comment on attachment 189022 [details]
Patch

tommyw, thanks for staging the changes like this
Comment 5 WebKit Review Bot 2013-02-19 12:38:18 PST 
Comment on attachment 189022 [details]
Patch

Clearing flags on attachment: 189022

Committed r143372: <http://trac.webkit.org/changeset/143372>
Comment 6 WebKit Review Bot 2013-02-19 12:38:23 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Jesus Sanchez-Palencia 2013-03-01 13:01:51 PST 
What is this new parameter (deviceID) meant for?
Comment 8 Chris Rogers 2013-03-01 13:15:52 PST 
This really should have been named "inputDeviceId".  It is a string identifier to specify the exact audio input device to use.  Many machines have more than one audio input device, so this needs to be specified.

This bug provides more background:
https://bugs.webkit.org/show_bug.cgi?id=109494
Comment 9 Jesus Sanchez-Palencia 2013-03-01 13:31:42 PST 
(In reply to comment #8)
> This really should have been named "inputDeviceId".  It is a string identifier to specify the exact audio input device to use.  Many machines have more than one audio input device, so this needs to be specified.
> 
> This bug provides more background:
> https://bugs.webkit.org/show_bug.cgi?id=109494

Thanks! I get it now.
It would be nice if the API was called using a const char* (WebString would need an extra implicit ctor, I guess) instead of a WTF::String directly, but we can workaround this.