WebAudio API: Change the Platform::createAudioDevice function to take a DeviceId parameter
Created attachment 189022 [details] Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment on attachment 189022 [details] Patch ok
Comment on attachment 189022 [details] Patch tommyw, thanks for staging the changes like this
Comment on attachment 189022 [details] Patch Clearing flags on attachment: 189022 Committed r143372: <http://trac.webkit.org/changeset/143372>
All reviewed patches have been landed. Closing bug.
What is this new parameter (deviceID) meant for?
This really should have been named "inputDeviceId". It is a string identifier to specify the exact audio input device to use. Many machines have more than one audio input device, so this needs to be specified. This bug provides more background: https://bugs.webkit.org/show_bug.cgi?id=109494
(In reply to comment #8) > This really should have been named "inputDeviceId". It is a string identifier to specify the exact audio input device to use. Many machines have more than one audio input device, so this needs to be specified. > > This bug provides more background: > https://bugs.webkit.org/show_bug.cgi?id=109494 Thanks! I get it now. It would be nice if the API was called using a const char* (WebString would need an extra implicit ctor, I guess) instead of a WTF::String directly, but we can workaround this.