WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
110192
WebAudio API: Change the Platform::createAudioDevice function to take a DeviceId parameter
https://bugs.webkit.org/show_bug.cgi?id=110192
Summary
WebAudio API: Change the Platform::createAudioDevice function to take a Devic...
Tommy Widenflycht
Reported
2013-02-19 01:32:59 PST
WebAudio API: Change the Platform::createAudioDevice function to take a DeviceId parameter
Attachments
Patch
(2.13 KB, patch)
2013-02-19 01:33 PST
,
Tommy Widenflycht
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1
2013-02-19 01:33:39 PST
Created
attachment 189022
[details]
Patch
WebKit Review Bot
Comment 2
2013-02-19 01:36:57 PST
Please wait for approval from
abarth@webkit.org
,
dglazkov@chromium.org
,
fishd@chromium.org
,
jamesr@chromium.org
or
tkent@chromium.org
before submitting, as this patch contains changes to the Chromium public API. See also
https://trac.webkit.org/wiki/ChromiumWebKitAPI
.
Adam Barth
Comment 3
2013-02-19 11:06:05 PST
Comment on
attachment 189022
[details]
Patch ok
Chris Rogers
Comment 4
2013-02-19 12:10:23 PST
Comment on
attachment 189022
[details]
Patch tommyw, thanks for staging the changes like this
WebKit Review Bot
Comment 5
2013-02-19 12:38:18 PST
Comment on
attachment 189022
[details]
Patch Clearing flags on attachment: 189022 Committed
r143372
: <
http://trac.webkit.org/changeset/143372
>
WebKit Review Bot
Comment 6
2013-02-19 12:38:23 PST
All reviewed patches have been landed. Closing bug.
Jesus Sanchez-Palencia
Comment 7
2013-03-01 13:01:51 PST
What is this new parameter (deviceID) meant for?
Chris Rogers
Comment 8
2013-03-01 13:15:52 PST
This really should have been named "inputDeviceId". It is a string identifier to specify the exact audio input device to use. Many machines have more than one audio input device, so this needs to be specified. This bug provides more background:
https://bugs.webkit.org/show_bug.cgi?id=109494
Jesus Sanchez-Palencia
Comment 9
2013-03-01 13:31:42 PST
(In reply to
comment #8
)
> This really should have been named "inputDeviceId". It is a string identifier to specify the exact audio input device to use. Many machines have more than one audio input device, so this needs to be specified. > > This bug provides more background: >
https://bugs.webkit.org/show_bug.cgi?id=109494
Thanks! I get it now. It would be nice if the API was called using a const char* (WebString would need an extra implicit ctor, I guess) instead of a WTF::String directly, but we can workaround this.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug