Bug 110186 - Web Inspector: Output of inspector-protocol/page/javascriptDialogEvents.html bleeds into other tests
Summary: Web Inspector: Output of inspector-protocol/page/javascriptDialogEvents.html ...
Status: RESOLVED DUPLICATE of bug 165507
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: EasyFix, GoodFirstBug, InRadar
Depends on:
Blocks: InspectorTest
  Show dependency treegraph
 
Reported: 2013-02-18 23:38 PST by Ryosuke Niwa
Modified: 2016-12-06 19:30 PST (History)
8 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-02-18 23:38:54 PST
WebKit:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=inspector%2Feditor%2Fbrace-matcher.html

Chromium:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=inspector%2Feditor%2Fbrace-matcher.html

e.g.
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r143294%20(6089)/results.html

--- /Volumes/Data/slave/mountainlion-release-tests-wk2/build/layout-test-results/inspector/editor/brace-matcher-expected.txt
+++ /Volumes/Data/slave/mountainlion-release-tests-wk2/build/layout-test-results/inspector/editor/brace-matcher-actual.txt
@@ -1,3 +1,4 @@
+CONFIRM NAVIGATION: beforeunload
 This test checks highlighter correctness.
 
 function bar() {

http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20%28Tests%29/builds/6089/steps/layout-test/logs/stdio
23:06:53.930 19936 worker/1 inspector-protocol/page/javascriptDialogEvents.html failed:
23:06:53.931 19936 worker/1  text diff
23:06:53.952 19942 worker/3 ietestcenter/Javascript/15.4.4.15-1-16.html passed
23:06:54.027 19942 worker/3 ietestcenter/Javascript/15.4.4.15-2-1.html passed
23:06:54.135 19942 worker/3 ietestcenter/Javascript/15.4.4.15-2-2.html passed
23:06:54.245 19942 worker/3 ietestcenter/Javascript/15.4.4.15-2-3.html passed
23:06:54.335 19933 worker/0 http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op.html passed
23:06:54.341 19942 worker/3 ietestcenter/Javascript/15.4.4.15-2-4.html passed
23:06:54.413 19948 worker/5 inspector/console/console-format-table.html passed
23:06:54.442 19942 worker/3 ietestcenter/Javascript/15.4.4.15-2-5.html passed
23:06:54.481 19933 worker/0 http/tests/websocket/tests/hybi/workers/no-subprotocol.html passed
23:06:54.503 19942 worker/3 ietestcenter/Javascript/15.4.4.15-2-6.html passed
23:06:54.599 19942 worker/3 ietestcenter/Javascript/15.4.4.15-2-7.html passed
23:06:54.685 19933 worker/0 http/tests/websocket/tests/hybi/workers/receive-arraybuffer.html passed
23:06:54.708 19942 worker/3 ietestcenter/Javascript/15.4.4.15-2-8.html passed
23:06:54.787 19942 worker/3 ietestcenter/Javascript/15.4.4.15-2-9.html passed
23:06:54.850 19933 worker/0 http/tests/websocket/tests/hybi/workers/receive-blob.html passed
23:06:54.854 19942 worker/3 ietestcenter/Javascript/15.4.4.15-2-10.html passed
23:06:54.939 19942 worker/3 ietestcenter/Javascript/15.4.4.15-2-11.html passed
23:06:54.985 19933 worker/0 http/tests/websocket/tests/hybi/workers/send-arraybuffer.html passed
23:06:55.049 19942 worker/3 ietestcenter/Javascript/15.4.4.15-2-12.html passed
23:06:55.083 19945 worker/4 inspector/debugger/debugger-pause-in-eval-script.html passed
23:06:55.118 19933 worker/0 http/tests/websocket/tests/hybi/workers/send-arraybufferview.html passed
23:06:55.147 19942 worker/3 ietestcenter/Javascript/15.4.4.15-2-13.html passed
23:06:55.225 19942 worker/3 ietestcenter/Javascript/15.4.4.15-2-14.html passed
23:06:55.240 19933 worker/0 http/tests/websocket/tests/hybi/workers/send-blob.html passed
23:06:55.332 19942 worker/3 ietestcenter/Javascript/15.4.4.15-2-15.html passed
23:06:55.422 19936 "ruby -I /Volumes/Data/slave/mountainlion-release-tests-wk2/build/Websites/bugs.webkit.org/PrettyPatch /Volumes/Data/slave/mountainlion-release-tests-wk2/build/Websites/bugs.webkit.org/PrettyPatch/prettify.rb /Volumes/Data/slave/mountainlion-release-tests-wk2/build/layout-test-results/inspector/editor/brace-matcher-diff.txt" took 0.19s
23:06:55.437 19909 [18593/29709] inspector/editor/brace-matcher.html failed unexpectedly (text diff)
23:06:55.424 19936 worker/1 inspector/editor/brace-matcher.html failed:
23:06:55.424 19936 worker/1  text diff
Comment 1 Ryosuke Niwa 2013-02-18 23:42:33 PST
Added a test expectation in http://trac.webkit.org/changeset/143301.
Comment 2 Ryosuke Niwa 2013-02-23 12:46:41 PST
Updated the test expectation to simply skip this test in http://trac.webkit.org/changeset/143849 since it was affecting multiple tests in non-deterministic fashion.
Comment 3 Radar WebKit Bug Importer 2014-12-17 11:24:45 PST
<rdar://problem/19281578>
Comment 4 Brian Burg 2014-12-17 12:47:38 PST
Updating title, since other test is gone. From looking at the test, somehow the runBeforeUnloadConfirmPanel callback in WKTR runs on a later test.

It looks fishy to me that the beforeunload is added outside of runTests(). This could be triggered during the initial load, not from the runTests.

However, I think the cause of the flakyness is that this is a protocol test that tries to navigate the inspected page. Since the stub inspector is a nested iframe, there is a race between the main frame ("inspected page") navigating and the test completing.
Comment 5 Joseph Pecoraro 2016-12-06 19:30:38 PST
I'm removing this test in bug 165507.

*** This bug has been marked as a duplicate of bug 165507 ***