Bug 110180 - Refactoring FixedTableLayout class for readability.
Summary: Refactoring FixedTableLayout class for readability.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tables (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Pravin D
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-18 22:46 PST by Pravin D
Modified: 2023-04-02 20:58 PDT (History)
6 users (show)

See Also:


Attachments
Patch (4.01 KB, text/plain)
2013-02-19 08:25 PST, Pravin D
no flags Details
Patch (4.34 KB, patch)
2013-02-19 08:42 PST, Pravin D
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pravin D 2013-02-18 22:46:40 PST
Refactoring the code width distribution code in FixedTableLayout::layout() for readability.
Comment 1 Pravin D 2013-02-19 08:25:46 PST
Created attachment 189093 [details]
Patch
Comment 2 Pravin D 2013-02-19 08:42:10 PST
Created attachment 189096 [details]
Patch
Comment 3 Julien Chaffraix 2013-02-19 11:15:25 PST
Comment on attachment 189096 [details]
Patch

Really not sure how much more clear this is but it's moot from my perspective.

As discussed on IRC, I would rather have the algorithm straightened up (like how we shrink looks suspicious (I would argue that shrinking is probably a wrong idea but that could be needed for compatibility)), maybe the different parts split up, unify the extra logical width spreading... This would lead to a much more readable code.
Comment 4 Andreas Kling 2014-02-05 11:11:07 PST
Comment on attachment 189096 [details]
Patch

Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
Comment 5 Ahmad Saleem 2023-04-02 08:03:20 PDT
@Alan - do we need to track it up, we can apply this patch (I looked into it) but I think Julien mentioned that it is not fixing much or anything.

I just trying to close old bugs so if we don't need to do anything, we can close this or if you want me to apply patch, I can try it with local build.

https://searchfox.org/wubkat/source/Source/WebCore/rendering/FixedTableLayout.cpp#266
Comment 6 zalan 2023-04-02 20:51:35 PDT
(In reply to Ahmad Saleem from comment #5)
> @Alan - do we need to track it up, we can apply this patch (I looked into
> it) but I think Julien mentioned that it is not fixing much or anything.
> 
> I just trying to close old bugs so if we don't need to do anything, we can
> close this or if you want me to apply patch, I can try it with local build.
> 
> https://searchfox.org/wubkat/source/Source/WebCore/rendering/
> FixedTableLayout.cpp#266
I wouldn't put too much effort into it.
Comment 7 Ahmad Saleem 2023-04-02 20:58:32 PDT
Closing this old bug now based on discussion with Alan. :-)