Refactoring the code width distribution code in FixedTableLayout::layout() for readability.
Created attachment 189093 [details] Patch
Created attachment 189096 [details] Patch
Comment on attachment 189096 [details] Patch Really not sure how much more clear this is but it's moot from my perspective. As discussed on IRC, I would rather have the algorithm straightened up (like how we shrink looks suspicious (I would argue that shrinking is probably a wrong idea but that could be needed for compatibility)), maybe the different parts split up, unify the extra logical width spreading... This would lead to a much more readable code.
Comment on attachment 189096 [details] Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
@Alan - do we need to track it up, we can apply this patch (I looked into it) but I think Julien mentioned that it is not fixing much or anything. I just trying to close old bugs so if we don't need to do anything, we can close this or if you want me to apply patch, I can try it with local build. https://searchfox.org/wubkat/source/Source/WebCore/rendering/FixedTableLayout.cpp#266
(In reply to Ahmad Saleem from comment #5) > @Alan - do we need to track it up, we can apply this patch (I looked into > it) but I think Julien mentioned that it is not fixing much or anything. > > I just trying to close old bugs so if we don't need to do anything, we can > close this or if you want me to apply patch, I can try it with local build. > > https://searchfox.org/wubkat/source/Source/WebCore/rendering/ > FixedTableLayout.cpp#266 I wouldn't put too much effort into it.
Closing this old bug now based on discussion with Alan. :-)