Bug 110165 - Merge handleSpecialChild into layoutBlockChildren
Summary: Merge handleSpecialChild into layoutBlockChildren
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Depends on:
Reported: 2013-02-18 16:24 PST by Ryosuke Niwa
Modified: 2013-02-20 10:28 PST (History)
7 users (show)

See Also:

Cleanup (3.93 KB, patch)
2013-02-18 16:28 PST, Ryosuke Niwa
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-02-18 16:24:32 PST
The name handleSpecialChild is extremely vague and doesn't communicate at all what it's handling and what "special" children are.

Since this function is only called by layoutBlockChildren, we can merge into layoutBlockChildren altogether.
In fact, handlePositionedChild and handleFloatingChild can also be merged into layoutBlockChildren.

That allows us to remove outdated comment in layoutBlockChildren that says:
// Handle the four types of special elements first.  These include positioned content, floating content, compacts and
// run-ins.  When we encounter these four types of objects, we don't actually lay them out as normal flow blocks.
which at this point is only half true.
Comment 1 Ryosuke Niwa 2013-02-18 16:28:47 PST
Created attachment 188960 [details]
Comment 2 Ryosuke Niwa 2013-02-18 19:44:10 PST
Committed r143290: <http://trac.webkit.org/changeset/143290>
Comment 3 Eric Seidel (no email) 2013-02-20 10:28:31 PST