Bug 110156 - Web Inspector: show source location after drawer views
Summary: Web Inspector: show source location after drawer views
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-18 14:56 PST by Andrey Lushnikov
Modified: 2013-02-22 07:56 PST (History)
9 users (show)

See Also:


Attachments
example (7.74 KB, image/jpeg)
2013-02-18 15:08 PST, Andrey Lushnikov
no flags Details
Patch (6.62 KB, patch)
2013-02-18 15:15 PST, Andrey Lushnikov
no flags Details | Formatted Diff | Diff
Patch (6.82 KB, patch)
2013-02-18 22:02 PST, Andrey Lushnikov
no flags Details | Formatted Diff | Diff
Patch (7.28 KB, patch)
2013-02-21 01:05 PST, Andrey Lushnikov
no flags Details | Formatted Diff | Diff
Patch (10.62 KB, patch)
2013-02-21 06:48 PST, Andrey Lushnikov
no flags Details | Formatted Diff | Diff
timeline with text which clarifies amount of selected ranges (7.34 KB, image/png)
2013-02-21 06:48 PST, Andrey Lushnikov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-02-18 14:56:06 PST
Show source location after drawer views.
Comment 1 Andrey Lushnikov 2013-02-18 15:08:25 PST
Created attachment 188947 [details]
example
Comment 2 Andrey Lushnikov 2013-02-18 15:15:46 PST
Created attachment 188948 [details]
Patch
Comment 3 Andrey Lushnikov 2013-02-18 22:02:17 PST
Created attachment 188987 [details]
Patch
Comment 4 Pavel Feldman 2013-02-19 06:21:43 PST
Comment on attachment 188987 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188987&action=review

> Source/WebCore/inspector/front-end/Panel.js:74
> +        panelStatusBar.appendChild(drawerViewAnchor);

You will end up with a lot of these.

> Source/WebCore/inspector/front-end/inspector.js:133
> +        var element = panelStatusBar.getElementsByClassName("drawer-view-anchor")[0];

It is bad to depend on the class that was added by a component.
Comment 5 Andrey Lushnikov 2013-02-21 01:05:10 PST
Created attachment 189470 [details]
Patch
Comment 6 Andrey Lushnikov 2013-02-21 06:48:05 PST
Created attachment 189520 [details]
Patch
Comment 7 Andrey Lushnikov 2013-02-21 06:48:46 PST
Created attachment 189521 [details]
timeline with text which clarifies amount of selected ranges
Comment 8 WebKit Review Bot 2013-02-22 07:55:58 PST
Comment on attachment 189520 [details]
Patch

Clearing flags on attachment: 189520

Committed r143729: <http://trac.webkit.org/changeset/143729>
Comment 9 WebKit Review Bot 2013-02-22 07:56:02 PST
All reviewed patches have been landed.  Closing bug.