Bug 110152 - Make HexNumber functions return 8-bit strings
Summary: Make HexNumber functions return 8-bit strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-18 13:30 PST by Alexey Proskuryakov
Modified: 2013-02-18 14:40 PST (History)
6 users (show)

See Also:

Attachments
proposed patch (3.53 KB, patch)
2013-02-18 13:36 PST, Alexey Proskuryakov 		msaboff: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-02-18 13:30:59 PST 
I'm seeing them unnecessarily make URLs 16-bit, blob ones in particular.
Comment 1 Alexey Proskuryakov 2013-02-18 13:36:59 PST 
Created attachment 188938 [details]
proposed patch
Comment 2 Michael Saboff 2013-02-18 13:55:16 PST 
Comment on attachment 188938 [details]
proposed patch

r+

I have a slight concern on platforms where char is signed that the compiler may complain for the cases we are adding an LChar to a char buffer.  An example is the call to placeByteAsHex in appendEscapedChar in KURL.cpp
Comment 3 WebKit Review Bot 2013-02-18 14:18:38 PST 
Comment on attachment 188938 [details]
proposed patch

Attachment 188938 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16613339

New failing tests:
fast/regions/seamless-iframe-flowed-into-regions.html
Comment 4 Alexey Proskuryakov 2013-02-18 14:40:38 PST 
Committed <http://trac.webkit.org/r143265>.

The failure looks unrelated.