Bug 110124 - Web Inspector: Native Memory Instrumentation: show user provided name property of the heap snapshot node
Summary: Web Inspector: Native Memory Instrumentation: show user provided name propert...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
Depends on:
Reported: 2013-02-18 08:43 PST by Ilya Tikhonovsky
Modified: 2013-02-19 04:23 PST (History)
8 users (show)

See Also:

Patch (5.17 KB, patch)
2013-02-18 08:45 PST, Ilya Tikhonovsky
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2013-02-18 08:43:13 PST
Some nodes have nonzero name property that was assigned via MemoryObjectInfo::setName method
This name may give the user a clue which particular object takes so much memory.

As example in case of WebCore::CachedImage the instrumentation provides url as the name of the object.
Comment 1 Ilya Tikhonovsky 2013-02-18 08:45:37 PST
Created attachment 188895 [details]
Comment 2 Yury Semikhatsky 2013-02-19 04:12:05 PST
Comment on attachment 188895 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=188895&action=review

> Source/WebCore/inspector/front-end/HeapSnapshotProxy.js:186
> +    this._worker = /*typeof InspectorTest === "undefined" ? new WebInspector.HeapSnapshotRealWorker() :*/ new WebInspector.HeapSnapshotFakeWorker();

Please revert this.

> Source/WebCore/inspector/front-end/NativeHeapSnapshot.js:112
> +            userProvidedName: this.name(),

displayName ?
Comment 3 Ilya Tikhonovsky 2013-02-19 04:23:09 PST
Committed r143317: <http://trac.webkit.org/changeset/143317>