RESOLVED FIXED 110121
Remove unnecessary (and problematic) copy-constructor from LayoutUnit 
https://bugs.webkit.org/show_bug.cgi?id=110121
Summary Remove unnecessary (and problematic) copy-constructor from LayoutUnit
Morten Stenshorne
Reported 2013-02-18 07:56:56 PST
This copy constructor does what a default copy constructor would do, so it's not necessary. Furthermore, this copy constructor is the only reason why LayoutUnit becomes non-POD, and that triggers a gdb bug, making it impossible to do things like "print location()" when inside some RenderBlock, for instance. Gdb bug http://sourceware.org/bugzilla/show_bug.cgi?id=15154 reported on that.
Attachments
Patch (1.78 KB, patch)
2013-02-18 08:04 PST, Morten Stenshorne 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Morten Stenshorne
Comment 1 2013-02-18 08:04:06 PST
Created attachment 188890 [details] Patch
WebKit Review Bot
Comment 2 2013-02-19 11:12:30 PST
Comment on attachment 188890 [details] Patch Clearing flags on attachment: 188890 Committed r143361: <http://trac.webkit.org/changeset/143361>
WebKit Review Bot
Comment 3 2013-02-19 11:12:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.