Bug 110121 - Remove unnecessary (and problematic) copy-constructor from LayoutUnit
Summary: Remove unnecessary (and problematic) copy-constructor from LayoutUnit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Morten Stenshorne
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-18 07:56 PST by Morten Stenshorne
Modified: 2013-02-19 11:12 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.78 KB, patch)
2013-02-18 08:04 PST, Morten Stenshorne 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Morten Stenshorne 2013-02-18 07:56:56 PST 
This copy constructor does what a default copy constructor would do, so it's not necessary. Furthermore, this copy constructor is the only reason why LayoutUnit becomes non-POD, and that triggers a gdb bug, making it impossible to do things like "print location()" when inside some RenderBlock, for instance. Gdb bug http://sourceware.org/bugzilla/show_bug.cgi?id=15154 reported on that.
Comment 1 Morten Stenshorne 2013-02-18 08:04:06 PST 
Created attachment 188890 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-19 11:12:30 PST 
Comment on attachment 188890 [details]
Patch

Clearing flags on attachment: 188890

Committed r143361: <http://trac.webkit.org/changeset/143361>
Comment 3 WebKit Review Bot 2013-02-19 11:12:33 PST 
All reviewed patches have been landed.  Closing bug.