Bug 110114 – Web Inspector: refactor statusBarItems getter in front-end

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Lushnikov]

- refactor "statusBarItems" methods from getters into functions
- move default implementation from Panel.js to View.js

[Andrey Lushnikov]

Created attachment 188876 [details]
Patch

[WebKit Review Bot]

Comment on attachment 188876 [details]
Patch

Rejecting attachment 188876 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Mátyás Mustoha]

Created attachment 203325 [details]
Patch

Updated the original patch.

[Build Bot]

Comment on attachment 203325 [details]
Patch

Attachment 203325 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/665614

New failing tests:
inspector/extensions/extensions-panel.html

[Build Bot]

Created attachment 203329 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Build Bot]

Comment on attachment 203325 [details]
Patch

Attachment 203325 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/692395

New failing tests:
inspector/extensions/extensions-panel.html

[Build Bot]

Created attachment 203341 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Build Bot]

Comment on attachment 203325 [details]
Patch

Attachment 203325 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/652610

New failing tests:
inspector/extensions/extensions-panel.html

[Build Bot]

Created attachment 203397 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Mátyás Mustoha]

Created attachment 203419 [details]
Fixed layout test: inspector/extensions/extensions-panel.html

[Noam Rosenthal]

Comment on attachment 203419 [details]
Fixed layout test: inspector/extensions/extensions-panel.html

Re-r+ing, since this was originally r+ed by Pavel Feldman.

[WebKit Commit Bot]

Comment on attachment 203419 [details]
Fixed layout test: inspector/extensions/extensions-panel.html

Clearing flags on attachment: 203419

Committed r151375: <http://trac.webkit.org/changeset/151375>