Bug 110114 - Web Inspector: refactor statusBarItems getter in front-end
Summary: Web Inspector: refactor statusBarItems getter in front-end
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks: 116924
  Show dependency treegraph
 
Reported: 2013-02-18 06:49 PST by Andrey Lushnikov
Modified: 2022-03-01 02:59 PST (History)
14 users (show)

See Also:


Attachments
Patch (22.55 KB, patch)
2013-02-18 06:57 PST, Andrey Lushnikov
pfeldman: review+
Details | Formatted Diff | Diff
Patch (19.34 KB, patch)
2013-05-30 01:55 PDT, Mátyás Mustoha
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (515.62 KB, application/zip)
2013-05-30 02:57 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (488.28 KB, application/zip)
2013-05-30 04:15 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (462.21 KB, application/zip)
2013-05-30 16:46 PDT, Build Bot
no flags Details
Fixed layout test: inspector/extensions/extensions-panel.html (21.06 KB, patch)
2013-05-31 00:59 PDT, Mátyás Mustoha
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-02-18 06:49:36 PST
- refactor "statusBarItems" methods from getters into functions
- move default implementation from Panel.js to View.js
Comment 1 Andrey Lushnikov 2013-02-18 06:57:48 PST
Created attachment 188876 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-18 11:02:36 PST
Comment on attachment 188876 [details]
Patch

Rejecting attachment 188876 [details] from commit-queue.

lushnikov@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 3 Mátyás Mustoha 2013-05-30 01:55:52 PDT
Created attachment 203325 [details]
Patch

Updated the original patch.
Comment 4 Build Bot 2013-05-30 02:57:12 PDT
Comment on attachment 203325 [details]
Patch

Attachment 203325 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/665614

New failing tests:
inspector/extensions/extensions-panel.html
Comment 5 Build Bot 2013-05-30 02:57:14 PDT
Created attachment 203329 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.3
Comment 6 Build Bot 2013-05-30 04:15:18 PDT
Comment on attachment 203325 [details]
Patch

Attachment 203325 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/692395

New failing tests:
inspector/extensions/extensions-panel.html
Comment 7 Build Bot 2013-05-30 04:15:20 PDT
Created attachment 203341 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.3
Comment 8 Build Bot 2013-05-30 16:46:06 PDT
Comment on attachment 203325 [details]
Patch

Attachment 203325 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/652610

New failing tests:
inspector/extensions/extensions-panel.html
Comment 9 Build Bot 2013-05-30 16:46:08 PDT
Created attachment 203397 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 10 Mátyás Mustoha 2013-05-31 00:59:56 PDT
Created attachment 203419 [details]
Fixed layout test: inspector/extensions/extensions-panel.html
Comment 11 Noam Rosenthal 2013-06-10 02:47:42 PDT
Comment on attachment 203419 [details]
Fixed layout test: inspector/extensions/extensions-panel.html

Re-r+ing, since this was originally r+ed by Pavel Feldman.
Comment 12 WebKit Commit Bot 2013-06-10 03:09:47 PDT
Comment on attachment 203419 [details]
Fixed layout test: inspector/extensions/extensions-panel.html

Clearing flags on attachment: 203419

Committed r151375: <http://trac.webkit.org/changeset/151375>