We sometimes use GOwnPtr to free the cookies, and sometimes free them manually using soup_cookie_free(). We should make this more consistent and use GOwnPtr as much as possible and this is the preferred pattern.
Created attachment 188851 [details] Patch
I agree with this change, but note that Martin was opposed to it, see the discussion in bug https://bugs.webkit.org/show_bug.cgi?id=82082.
(In reply to comment #2) > I agree with this change, but note that Martin was opposed to it, see the discussion in bug https://bugs.webkit.org/show_bug.cgi?id=82082. Ok, clearing commit flag for now then. I assumed this was fine because GOwnPtr is already used this way in getRawCookies() and deleteCookie(). We should be consistent (either way). We have 2 functions uses GOwnPtr and 2 using soup_cookie_free(). I'll wait for Martin to comment on this.
Comment on attachment 188851 [details] Patch Based on IRC discussion with Martin Robinson, I'll upload a patch harmonizing the other way around (freeing explicitly).
Created attachment 188908 [details] Patch
Comment on attachment 188908 [details] Patch Clearing flags on attachment: 188908 Committed r143243: <http://trac.webkit.org/changeset/143243>
All reviewed patches have been landed. Closing bug.