Bug 110100 - [Soup] CookieJarSoup::deleteCookie() should stop looking for the cookie after it is removed
Summary: [Soup] CookieJarSoup::deleteCookie() should stop looking for the cookie after...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-18 04:07 PST by Chris Dumez
Modified: 2013-02-18 05:31 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.03 KB, patch)
2013-02-18 04:28 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-02-18 04:07:50 PST 
CookieJarSoup::deleteCookie() currently retrieves the list of cookies that apply to a given URL, then iterates through the cookies to find the one with the right name and delete it. However, the current implementation does not break when the cookie is removed and it keeps iterating through the whole list for no reason.
Comment 1 Chris Dumez 2013-02-18 04:20:53 PST 
Actually, we need to keep iterating so that the cookies get freed. However, we can introduce a boolean to stop comparing cookie names after the cookie was removed.
Comment 2 Chris Dumez 2013-02-18 04:28:26 PST 
Created attachment 188847 [details]
Patch
Comment 3 Chris Dumez 2013-02-18 04:59:50 PST 
Could someone from GTK port please take a look before landing this?
Comment 4 Carlos Garcia Campos 2013-02-18 05:15:32 PST 
LGTM
Comment 5 WebKit Review Bot 2013-02-18 05:31:16 PST 
Comment on attachment 188847 [details]
Patch

Clearing flags on attachment: 188847

Committed r143204: <http://trac.webkit.org/changeset/143204>
Comment 6 WebKit Review Bot 2013-02-18 05:31:20 PST 
All reviewed patches have been landed.  Closing bug.