Bug 110061 - AX: rename WebAccessibilityObjectWrapper to WebAccessibilityObjectWrapperBase
Summary: AX: rename WebAccessibilityObjectWrapper to WebAccessibilityObjectWrapperBase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-17 13:16 PST by chris fleizach
Modified: 2013-02-17 19:37 PST (History)
1 user (show)

See Also:

Attachments
patch (200.28 KB, patch)
2013-02-17 13:33 PST, chris fleizach 		no flags Details | Formatted Diff | Diff
patch (200.99 KB, patch)
2013-02-17 13:49 PST, chris fleizach 		ddkilzer: review+
ddkilzer: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2013-02-17 13:16:06 PST 
Then that way WebAccessibilityObjectWrapperMac and WebAccessibilityObjectWrapperIOS can just be WebAccessibilityObjectWrapper and things will be a bit cleaner
Comment 1 chris fleizach 2013-02-17 13:33:04 PST 
Created attachment 188773 [details]
patch
Comment 2 chris fleizach 2013-02-17 13:34:21 PST 
Xcode keeps trying to reorder these other changes in the Xcode project, so maybe i shouldn't fight them anymore
Comment 3 chris fleizach 2013-02-17 13:49:27 PST 
Created attachment 188775 [details]
patch
Comment 4 David Kilzer (:ddkilzer) 2013-02-17 18:35:40 PST 
Comment on attachment 188775 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188775&action=review

r=me as long as you don't rename WebAccessibilityObjectWrapperMac.{h|mm} to remove "Mac" from the name.

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm:30
> -#import "WebAccessibilityObjectWrapperMac.h"
> +#import "WebAccessibilityObjectWrapper.h"

Please leave these files named as WebAccessibilityObjectWrapperMac.{h|mm} even though the class is named "WebAccessibilityObjectWrapper" so that it's easier to know which implementation is being included or compiled.
Comment 5 David Kilzer (:ddkilzer) 2013-02-17 18:36:39 PST 
(In reply to comment #2)
> Xcode keeps trying to reorder these other changes in the Xcode project, so maybe i shouldn't fight them anymore

Yes, whoever changed these files didn't use Xcode to change them since the UUID sort order is borked.  It's fine to let Xcode have its way with the project file.
Comment 6 chris fleizach 2013-02-17 19:37:16 PST 
http://trac.webkit.org/changeset/143142